1821901 - Convert toolkit/components/timermanager to ES modules

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Anwar Sadat Ayub]

I am working on it

Comment 2

[Ishpreet Kaur]

I am an outreachy intern. Will be working on this.

Comment 3

[Anwar Sadat Ayub]

After running the ./mach esmify --import . --prefix path/to/files , I got the error unexpected reserved word 'private' in the file toolkit\components\resistfingerprinting\tests\browser\browser_fingerprinting_randomization_key.js.
How do go about this?

Comment 4

[Mark Banner (:standard8)]

(In reply to Anwar Sadat Ayub from comment #3)

After running the ./mach esmify --import . --prefix path/to/files , I got the error unexpected reserved word 'private' in the file toolkit\components\resistfingerprinting\tests\browser\browser_fingerprinting_randomization_key.js.
How do go about this?

I assume that is from this code.

This is saying that private is normally expected to be used only in particular situations, and not as a variable name. Hence in this case you can change the for loop variable to something else, I think I would go with testPrivateWin. You'll need to change where that variable is used within the loop as well.

Comment 5

[Anwar Sadat Ayub]

That's exactly where the code is and thanks for the guide

Comment 6

[Ekene Nwobodo]

I will take a look at this if it hasn't been assigned.

Comment 7

[Mark Banner (:standard8)]

(In reply to Ekene Nwobodo from comment #6)

I will take a look at this if it hasn't been assigned.

Please make sure you read the comments, especially the first line of comment 0. Anwar is already working on this.

Comment 8

[Ekene Nwobodo]

(In reply to Mark Banner (:standard8) from comment #7)

(In reply to Ekene Nwobodo from comment #6)

I will take a look at this if it hasn't been assigned.

Please make sure you read the comments, especially the first line of comment 0. Anwar is already working on this.

No problems. Thanks

Comment 9

[Anwar Sadat Ayub]

Attachment: Bug 1821901 - Convert toolkit/components/timermanager to ES modules.r?Standard8

Comment 10

[Phabricator Automation]

Comment on attachment 9322937 [details]
Bug 1821901 - Convert toolkit/components/timermanager to ES modules.r?Standard8

Revision D172548 was moved to bug 1822336. Setting attachment 9322937 [details] to obsolete.

Comment 11

[Anwar Sadat Ayub]

Attachment: Bug 1821901 - Convert toolkit/components/timermanager to ES modules. r?Standard8

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27be9a7030c1
Convert toolkit/components/timermanager to ES modules. r=Standard8

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/27be9a7030c1