1821299 - Convert toolkit/components/bitsdownload/ to ES modules

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Check for any comment references to the .jsm file and update them
  6. Run a build to check it passes.
  7. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  8. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Sauvic Paul Choudhury[:sauvic]]

I'm working on it .

Comment 2

[ksatyam433]

Hi there I want to work on this issue can You assist me

Comment 3

[Mark Banner (:standard8)]

(In reply to ksatyam433 from comment #2)

Hi there I want to work on this issue can You assist me

Hi ksatyam433, please check other comments before commenting on bugs - you can see that :sauvic has already said they're working on this just a little bit before you, so please be respectful and give them a bit of time. There should be plenty of other bugs about, or you can ask the project mentors.

Comment 4

[ksatyam433]

Sure Thank You

Comment 5

[Sauvic Paul Choudhury[:sauvic]]

Hi Mark, I came across the error "toolkit\components\bitsdownload\Bits.jsm , Tranformation error (exported symbols BitsSuccess not found) " after implementing the first command ie "./mack esmify --convert toolkit/components/bitsdownload/" . As I was looking for the BItsSuccess symbol I found out it was used without any declaration or I could not found the declaration. Im thinking on commenting it out, please help me with this. Thank you.

Comment 6

[Mark Banner (:standard8)]

(In reply to Sauvic Paul Choudhury[:sauvic] from comment #5)

Hi Mark, I came across the error "toolkit\components\bitsdownload\Bits.jsm , Tranformation error (exported symbols BitsSuccess not found) " after implementing the first command ie "./mack esmify --convert toolkit/components/bitsdownload/" . As I was looking for the BItsSuccess symbol I found out it was used without any declaration or I could not found the declaration. Im thinking on commenting it out, please help me with this. Thank you.

You're right, that is not declared anywhere, and neither does anything try to use it: https://searchfox.org/mozilla-central/search?q=BitsSuccess&redirect=false

I would suggest that you delete the line "BitsSuccess", and then re-run the command.

Comment 7

[Sauvic Paul Choudhury[:sauvic]]

(In reply to Mark Banner (:standard8) from comment #6)

(In reply to Sauvic Paul Choudhury[:sauvic] from comment #5)

Hi Mark, I came across the error "toolkit\components\bitsdownload\Bits.jsm , Tranformation error (exported symbols BitsSuccess not found) " after implementing the first command ie "./mack esmify --convert toolkit/components/bitsdownload/" . As I was looking for the BItsSuccess symbol I found out it was used without any declaration or I could not found the declaration. Im thinking on commenting it out, please help me with this. Thank you.

You're right, that is not declared anywhere, and neither does anything try to use it: https://searchfox.org/mozilla-central/search?q=BitsSuccess&redirect=false

I would suggest that you delete the line "BitsSuccess", and then re-run the command.

Im getting this error whenever i try to do hg add
File "mercurial\extensions.pyc", line 270, in runextsetup
File "C:/Users/sauvic/.mozbuild/version-control-tools/hgext\firefoxtree_init.py", line 705, in extsetup
extensions.wrapfunction(hg, b"_peerorrepo", peerorrepo)
File "mercurial\extensions.pyc", line 675, in wrapfunction
File "mercurial\pycompat.pyc", line 358, in w
AttributeError: module 'mercurial.hg' has no attribute '_peerorrepo'
*** failed to set up extension firefoxtree: module 'mercurial.hg' has no attribute '_peerorrepo'.
Please help with this.

Comment 8

[Sauvic Paul Choudhury[:sauvic]]

Im sorry I have asked my setup related problems here.

Comment 9

[Sauvic Paul Choudhury[:sauvic]]

Attachment: Bug 1821299 - Convert toolkit/components/bitsdownload to ES modules. r=Standard8

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0f77f6e86c
Convert toolkit/components/bitsdownload to ES modules. r=Standard8,application-update-reviewers,nalexander

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9b0f77f6e86c