1820883 - Convert toolkit/components/autocomplete to ES modules

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, task)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Leslie]

Hi there, currently working on this one. Just having trouble between committing the changes and moz-phab. When I do hg commit, a new window pops up and I write my commit message but can't seem to save it and get back to my original terminal screen.

Comment 2

[Leslie]

Attachment: Bug 1820883 - Convert toolkit/components/autocomplete to ES modules. r?Standard8

r?Standard8

Comment 3

[Mark Banner (:standard8)]

Thank you for the patch. I think you missed adding the me as the reviewer in the commit message, which is why it is marked as WIP. If in the next commit you modify the commit message to include r?Standard8 (on the first line), then it should change to non-WIP.

Additionally, for some reason the scripts are missing a required change. You'll need to change this line to be:

            'esModule': 'resource://gre/modules/AutoCompleteSimpleSearch.sys.mjs',

There's some docs here on how to update the patch if you need them.

Comment 4

[Leslie]

I don't know if the name for the commit was too long and that's why it wasn't working for me, but if I kept it as it was, the r?Standard8 would go to a new line and would not be included in my commit message. So I shortened it in order to add you as a reviewer but let me know if I should revert it back since the path/to/files is not precise. Do you know how I can keep the commit message long and the reviewer all in one line?

Also, is the updated patch, with updated change correct?
Thank you!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3f7b587ff20
Convert toolkit/components/autocomplete to ES modules. r=credential-management-reviewers,dimi

Comment 6

[Mark Banner (:standard8)]

(In reply to Leslie from comment #4)

I don't know if the name for the commit was too long and that's why it wasn't working for me, but if I kept it as it was, the r?Standard8 would go to a new line and would not be included in my commit message. So I shortened it in order to add you as a reviewer but let me know if I should revert it back since the path/to/files is not precise. Do you know how I can keep the commit message long and the reviewer all in one line?

Ah, that might be due to something in your editor. Most editors should be able to allow longer commit messages. Also, if you use hg commit -m "<message>" on the command line, that will let you have a message of any length as well.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a3f7b587ff20