1820882 - Convert toolkit/crashreporter to ES modules

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  4. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  5. Again, check for any errors and fix them.
  6. Run a build to check it passes.
  7. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  8. Commit the changes with a commit message such as "Bug nnnnnn - Convert consumers of path/to/files to import ES modules directly. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[ianiket23]

Hey Mark, I am taking a look into this bug.

Comment 2

[ianiket23]

Attachment: Bug 1820882 - Convert consumers of toolkit/crashreporter to import ES modules directly. r?Standard8

Comment 3

[ianiket23]

Hey Mark, I submitted my patch. This is my first open source contribution! Please let me know if I did something wrong:)

Comment 4

[ianiket23]

Attachment: Bug 1820882 - Convert consumers of toolkit/crashreporter to import ES modules directly. r?Standard8

Depends on D171959

Comment 5

[ianiket23]

Attachment: Bug 1820882 - Convert consumers of toolkit/crashreporter to import ES modules directly. r?Standard8

Depends on D171966

Comment 6

[ianiket23]

D171967 is the most recent revision. It passes the test.

Comment 7

[Mark Banner (:standard8)]

(In reply to ianiket23 from comment #6)

D171967 is the most recent revision. It passes the test.

When modifying code, please don't create new revisions, but modify your existing commit - see the documentation here for how to do that.

Also, please can you abandon the unwanted revisions - to do that, go into each revision on phabricator, and scroll down to the bottom. Just above the comment box, there is an action box that lets you select "Abandon Revision", you can then submit that and it'll be marked as obsolete.

Comment 8

[ianiket23]

(In reply to Mark Banner (:standard8) from comment #7)

(In reply to ianiket23 from comment #6)

D171967 is the most recent revision. It passes the test.

When modifying code, please don't create new revisions, but modify your existing commit - see the documentation here for how to do that.

Also, please can you abandon the unwanted revisions - to do that, go into each revision on phabricator, and scroll down to the bottom. Just above the comment box, there is an action box that lets you select "Abandon Revision", you can then submit that and it'll be marked as obsolete.

I will do that for next time!
Also, I abandoned the unwanted revision.

Comment 9

[Mark Banner (:standard8)]

Did you see my comments on the phabricator revision? It seems that the wrong patch is in the queue.

Comment 10

[ianiket23]

I will fix it, submit a new revision!

Comment 11

[ianiket23]

Attachment: Bug 1820882 - Convert consumers of toolkit/crashreporter to import ES modules directly r?Standard8

Comment 12

[ianiket23]

I submitted a new revision!

Comment 13

[ianiket23]

I reverted the changes you asked for

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/474472954034
Convert consumers of toolkit/crashreporter to import ES modules directly r=Standard8

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/474472954034