1817303 - Enable scroll-driven animations on Nightly

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task)

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1817303 - Enable scroll-driven animations on Nightly.

We have some basic implementation already, and it'd be better to enable
this perference earlier for interop estimation purpose, so we can show the
correct result on web-platform-tests dashboard.

Comment 2

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/jobs?repo=try&revision=334cc4eb44cca39eafa8809025210b2868b94771

Comment 3

[Boris Chiou [:boris]]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=bccc38c2d9c0cfe197b6f026f4fbb811635796a0 (on the top of Bug 1943206)

Comment 4

[Boris Chiou [:boris]]

Per https://treeherder.mozilla.org/jobs?repo=try&revision=334cc4eb44cca39eafa8809025210b2868b94771&selectedTaskRun=FkqsN6kAQ8izNdOqjqiClg.0&searchStr=Linux%2C18.04%2Cx64%2CWebRender%2Cdebug%2CWeb%2Cplatform%2Ctests%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests%2Cwpt8

There are some failures in css/css-animations/parsing/animation-computed.html. So we probably have to upload a patch which enable the preference in this folder first and fix the failures.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1817303 - Enable scroll-driven animations pref for tests in css-animations.

Also, we have to tweak the serialization of animation shorthand.
We serialize animation shorthand only when animation-timeline is the
initial value (i.e. time-driven animations), so the resolved value of
animation-duration component is always 0s.

Comment 6

[Boris Chiou [:boris]]

try with the new patch: https://treeherder.mozilla.org/jobs?repo=try&revision=614f9763f380473562fc1d736dcecc4eeba3f2ee

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a2a5a8dcedc
Enable scroll-driven animations pref for tests in css-animations. r=layout-reviewers,dholbert
https://hg.mozilla.org/integration/autoland/rev/0220f4ba6368
Enable scroll-driven animations on Nightly. r=layout-reviewers,dholbert

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6a2a5a8dcedc
https://hg.mozilla.org/mozilla-central/rev/0220f4ba6368

Comment 9

[Donal Meehan [:dmeehan]]

:boris could you consider nominating this for a release note? (Process info)
We could include it in the nightly only release notes.

Comment 10

[Boris Chiou [:boris]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We enable scroll-driven animations for experimental purpose. There are some basic implementation in Gecko, and after enabling this feature on Nightly we can show the proper status on WPT dashboard, for interop purpose. That means all browser vendors can understand Gecko implementation status via Web-platform tests, and it'd be easier for us to make the decision to champion scroll-driven animations into the focus areas in the following years.
[Affects Firefox for Android]: Yes
[Suggested wording]: Enable scroll-driven animations experimentally in Nightly.
[Links (documentation, blog post, etc)]: https://groups.google.com/a/mozilla.org/g/dev-platform/c/d8k74ywuFNQ/m/GhdIaDDbCQAJ

Comment 11

[Boris Chiou [:boris]]

We can see our current implementation status on WPT dashboard now, e.g. https://wpt.fyi/results/scroll-animations?label=master&label=experimental&product=chrome&product=firefox&aligned.

The score is about 47% today.

Comment 12

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx136 nightly release notes, please allow 30 minutes for the site to update.

Comment 13

[Dave Letorey]

Associated PR

• FF Release note PR

Comment 14

[Donal Meehan [:dmeehan]]

Per standard practice, this has been in Nightly release notes for 3+ versions, so removing from the Nightly release notes for Fx140+
Later inclusion in release notes can be added once this is enabled by default.