1817122 - Use ToggleEvent interface for <details> element toggle event

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Tim Nguyen :ntim]

https://github.com/whatwg/html/pull/8893

Comment 2

[zsun]

@emilio, this was initially marked as blocking popover feature. Now I look at it and don't think it's in popover scope. I just removed this block. Is it Okay?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

(In reply to zsun from comment #2)

@emilio, this was initially marked as blocking popover feature. Now I look at it and don't think it's in popover scope. I just removed this block. Is it Okay?

FWIW if you want an answer it's better to use the needinfo flag because otherwise it's easy to miss. This is not particularly related to popover, I agree. Though it's kinda trivial

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817122 - Make AsyncEventDispatcher(Event) take ownership of the event. r=smaug,masayuki

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817122 - Use a ToggleEvent for <details> toggle event. r=smaug

Depends on D190059

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7683643c809e
Make AsyncEventDispatcher(Event) take ownership of the event. r=smaug,media-playback-reviewers,padenot

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10bb8a2e7948
Fix linux base toolchains build.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a879c4fcdc4f
Use a ToggleEvent for <details> toggle event. r=smaug

Comment 9

[Norisz Fay [:noriszfay]]

Backed out changeset a879c4fcdc4f for causing multiple failures

Backout link

Push with failures 1
Push with failures 2
Push with failures 3

Failure log 1
Failure log 2
Failure log 3

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7683643c809e
https://hg.mozilla.org/mozilla-central/rev/10bb8a2e7948

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d552f1a7e7d
Use a ToggleEvent for <details> toggle event. r=smaug

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5d552f1a7e7d

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:emilio, maybe it's time to close this bug?
For more information, please visit BugBot documentation.