1809776 - Cut GamePads over to Fine-Grained RFP Control

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Tom Ritter [:tjr]]

Almost all of GamePadManager.cpp uses the new ShouldRFP functions on the Window object, this lets you exempt specific domains from RFP. However right here we check the general preference. AIUI this check in turn means a ton of other behavior will never happen, because we never Add any Gamepads, so the Gamepad Manager never even has any gamepads to do anything with.

So while it would be easy to remove that check, and then add a (redundant) listeners[i]->ShouldResistFingerprinting() a little further down - I'll probably need to audit all of the GamePad code to ensure that nothing somewhere else (like FireButtonEvent to pick one at random) will cause a GamePad event to get dispatched to a window where RFP is enabled.

Comment 1

[Tom Schuster (MoCo)]

We only add listeners (windows) that don't resist fingerprinting: https://searchfox.org/mozilla-central/rev/7426a35738cd542b9488c7b67f4f6d21edfeda0a/dom/gamepad/GamepadManager.cpp#147-149. I think that means all other checks are superfluous.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1809776: Cut Gamepads over to fine-grained RFP control r?cmartin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0c8af811fae
Cut Gamepads over to fine-grained RFP control r=cmartin,tschuster

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f0c8af811fae