1804103 - [wpt-sync] Sync PR 37329 - Fix resolving of SMIL intervals in the past

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37329 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37329
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix resolving of SMIL intervals in the past

If the only active interval of a timed element was in the past when the
first interval was resolved, no interval would be resolved. This in turn
could mean that animation that should still apply after the active
duration ended (i.e because of fill=freeze) did not.

When computing the first interval for a timed element, then store/update
interval state after each resolved interval that is reject (because it's
in the past). This means that the initial interval state will reflect
the same state that it would get from essentially fast-fowarding through
the intervals. If an unresolved interval ends up being returned from
ResolveInterval() - like in the bug in question - then it will move the
previously resolved interval (interval_) into previous_interval_.
Thus there's no need to update previous_interval_ in the resolve loop.
Setting is_waiting_for_first_interval_ means that the correct active
state will be computed by DetermineActiveState().

Fixed: 1395605
Change-Id: Iac185713f298608bd1d3337425fe32188a7670fe
Reviewed-on: https://chromium-review.googlesource.com/4079445
WPT-Export-Revision: 5193e689b1b6f07a35f2235e301b90217352503b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=09f80e529975d5e8938a796d003ba13d12bb2772

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 2

Chrome

OK : 2
PASS : 1
FAIL : 1

Safari

TIMEOUT: 4

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a03cb0af68
[wpt PR 37329] - Fix resolving of SMIL intervals in the past, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e5a03cb0af68