Closed Bug 1803439 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 37263 - WPT disabled-event-dispatch: run asserts even for skipped events

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37263 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37263
Details from upstream follow.

Mustaq Ahmed <mustaq@google.com> wrote:

WPT disabled-event-dispatch: run asserts even for skipped events

The test currently skips asserts for missing events. While this is
correct, it causes wpt run to emit the message "No asserts ran"
when none of the three events are expected (e.g. with "mousedown"
event plus clickChildElement == false). This CL adds explicit
assertions for the three events, making the assert messages a bit
clearer.

Bug: 588760
Change-Id: I647fd777904c2e0b0d4ea12d83d71bc750f9f7ec
Reviewed-on: https://chromium-review.googlesource.com/4068221
WPT-Export-Revision: af8159db00243dbcecc79b69ad7995e90621d199

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
PASS: 10

Chrome

OK : 1
PASS: 10

Safari

OK : 1
PASS: 3
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6cd89ea7857 [wpt PR 37263] - WPT disabled-event-dispatch: run asserts even for skipped events, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.