1801416 - Esmifying without import changes causes test failure from browser_all_files_referenced.js

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Because the test thinks the new .sys.mjs file is never imported.

This can happen when the module is only imported by components from different directories.

Not sure how worth the fix would be, but anyway filing this so that it can be tracked.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1801416 - Remove remaining references to jsm files in browser_all_files_referenced.js. r?Gijs!

Comment 2

[Mark Banner (:standard8)]

The patch I've just added ends up removing the remaining references to jsm files. We're at the stage now where most files are converted, and we shouldn't be hitting this again.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29325effffdb
Remove remaining references to jsm files in browser_all_files_referenced.js. r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1801416, Bug 1845064) for causing failures in browser_all_files_referenced.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=cWQJgDiES1em_Wl6ixSa2g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6588b692c52d94e933485af2756257f00c143078

Log: https://treeherder.mozilla.org/logviewer?job_id=423706588&repo=autoland&lineNumber=4208

Backout: https://hg.mozilla.org/integration/autoland/rev/3aee930a9705f1eed92ab38239318a2f735fc7ea

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97d46689ef0a
Remove remaining references to jsm files in browser_all_files_referenced.js. r=Gijs

Comment 6

[Noemi Erli[:noemi_erli]]

This was relanded, apologies for the inconvenience

Comment 7

[Serban Stanca [:SerbanS]]

Backed out after all for causing mochitests failures in browser_parsable_css.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://browser/skin/translations/panel.css: Unexpected token ‘and’ in media list. -

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ef497d4d1b8
Remove remaining references to jsm files in browser_all_files_referenced.js. r=Gijs

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8ef497d4d1b8

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8ef497d4d1b8