1797449 - (interop-2024-websockets) WebSocket: Allow relative URLs and http(s) scheme

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P3)

Description

[snek]

Steps to reproduce:

See: https://github.com/whatwg/websockets/pull/37 & https://github.com/whatwg/websockets/issues/20

Comment 1

[snek]

Working on this in https://phabricator.services.mozilla.com/D160330

Comment 2

[snek]

Attachment: Bug 1797449 - [websocket] Allow relative URLs and http(s) scheme

Refs: https://github.com/whatwg/websockets/pull/37
Refs: https://github.com/whatwg/websockets/issues/20

Comment 3

[snek]

Attachment: WIP: Bug 1797449 - WebSocket: Allow relative URLs and http(s) scheme

Comment 4

[m.kurz]

Webkit implemented this recently and upcoming Safari 17 will ship that feature:

• https://github.com/WebKit/WebKit/pull/13751
• https://bugs.webkit.org/show_bug.cgi?id=247149

would be nice if others catch up also.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 6

[Oliver Medhurst [:canadahonk]]

Happy to finish this off if there are no concerns otherwise?

Comment 7

[Valentin Gosu [:valentin] (he/him)]

(In reply to Oliver Medhurst [:canadahonk] from comment #6)

Happy to finish this off if there are no concerns otherwise?

Go for it. I think the patch is nearly there. Some WPT expectations needed fixing.

Comment 8

[m.kurz]

Happy to finish this off if there are no concerns otherwise?

Looking forward having this in Firefox now that Safari 17 already shipped that enhancement. Thanks!

Comment 9

[Oliver Medhurst [:canadahonk]]

Intent to prototype and ship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/1je37gGZel0

Comment 10

[Oliver Medhurst [:canadahonk]]

Standards position: https://github.com/mozilla/standards-positions/issues/966

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f27806eac17b
[websocket] Allow relative URLs and http(s) scheme r=valentin

Comment 12

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failure on test_websocket1.html

Backout link

Push with failures

Failure log

Comment 13

[Oliver Medhurst [:canadahonk]]

Some internal tests checked we didn't support this. Updated so they should expect so. Updated patch and pushed to try, I'll land again if it looks okay.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57780f6a56b
[websocket] Allow relative URLs and http(s) scheme r=valentin

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e57780f6a56b

Comment 16

[Oliver Medhurst [:canadahonk]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New web platform feature
[Affects Firefox for Android]: Yes
[Suggested wording]: You can now use HTTP(S) and relative URLs when creating WebSockets.
[Links (documentation, blog post, etc)]: https://github.com/whatwg/websockets/pull/45

Comment 17

[Dianna Smith [:diannaS]]

Added to Fx124 nightly notes https://www.mozilla.org/en-US/firefox/124.0a1/releasenotes/ and the draft for the final release notes.

Comment 18

[Hamish Willee]

MDN docs for this completed except for a few reviews - tracked in https://github.com/mdn/content/issues/26731