1796143 - ./mach esmify should handle sjs files as well

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Mark Banner (:standard8)]

Currently ./mach esmify doesn't update .sjs files, we should add that as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1796143 - Allow esmify to fix sjs files. r?arai

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1796143 - Update *.sjs files for imports that have already been transitioned to ES module files. r?arai

Depends on D159708

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1796143 - Add some new modules to esmify's map. r?arai

Depends on D159709

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=48f3efd7c7ae67ec0c396ee78cd8331eae8b5815

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61a9ae6c1a8f
Allow esmify to fix sjs files. r=arai
https://hg.mozilla.org/integration/autoland/rev/680008b18ad1
Update *.sjs files for imports that have already been transitioned to ES module files. r=arai,extension-reviewers,credential-management-reviewers,willdurand
https://hg.mozilla.org/integration/autoland/rev/d02d2c2ad921
Add some new modules to esmify's map. r=arai

Comment 6

[Iulian Moraru]

Backed out for causing mochitest failures on test_double_submit.html.
The only affected platform, so far, seems to be Android 7.0 x86-64.

Push with failures

Failure log

Backout link

[task 2022-10-20T19:13:53.082Z] 19:13:53     INFO -  TEST-START | docshell/test/mochitest/test_double_submit.html
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -  Buffered messages logged at 19:13:42
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -  add_task | Entering runTest
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -  Buffered messages finished
[task 2022-10-20T19:18:55.903Z] 19:18:55  WARNING -  TEST-UNEXPECTED-FAIL | docshell/test/mochitest/test_double_submit.html | Test timed out. -
[task 2022-10-20T19:18:55.903Z] 19:18:55  WARNING -  TEST-UNEXPECTED-FAIL | docshell/test/mochitest/test_double_submit.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:414:16
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -      afterCleanup@SimpleTest/SimpleTest.js:1416:18
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1492:7
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1512:3
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -      killTest@SimpleTest/TestRunner.js:195:22
[task 2022-10-20T19:18:55.903Z] 19:18:55     INFO -  TEST-OK | docshell/test/mochitest/test_double_submit.html | took 308806ms
[task 2022-10-20T19:18:55.904Z] 19:18:55  WARNING -  TEST-UNEXPECTED-FAIL | /tests/docshell/test/mochitest/test_double_submit.html logged result after SimpleTest.finish(): [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2022-10-20T19:18:55.904Z] 19:18:55     INFO -  TEST-START | docshell/test/mochitest/test_forceinheritprincipal_overrule_owner.html

Comment 7

[Mark Banner (:standard8)]

Somehow my ./mach try auto push missed that. This needs hostutils updating (which is already in progress) - bug 1792805.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/501960a11d29
Allow esmify to fix sjs files. r=arai
https://hg.mozilla.org/integration/autoland/rev/4b5db6c6b5c9
Update *.sjs files for imports that have already been transitioned to ES module files. r=arai,extension-reviewers,credential-management-reviewers,willdurand
https://hg.mozilla.org/integration/autoland/rev/28f47c2800e9
Add some new modules to esmify's map. r=arai

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/501960a11d29
https://hg.mozilla.org/mozilla-central/rev/4b5db6c6b5c9
https://hg.mozilla.org/mozilla-central/rev/28f47c2800e9