1794697 - ./mach esmify rewrites some files with Windows style line endings.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nick Rishel [:nrishel]]

Some files seem to be rewritten with Windows style line endings when using ./mach esmify. Example - see files where all lines are diffed.

This may not warrant investigation since esmify should be a short lived tool, but wanted to put it on the record in case it's a trivial fix.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

(Let's follow the component of the parent bug)

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1794697 - Pass newline=\n when esmifying r=arai

Python's write('w') by default uses system default line ending which is \r\n in Windows. newline=\n helps us to keep using \n everywhere.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c591d2d21ae
Pass newline=\n when esmifying r=arai DONTBUILD

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5c591d2d21ae