1792398 - Enable ESLint rule strict on mjs / module files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

The ESLint strict rule, will disallow "use strict"; in files it knows are modules.

Since modules are run in strict mode already, the "use strict"; directive is not necessary.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r?arai

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/849faf753208
Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_sendQuery.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4dac14712a2f3f3bc3fe8e4d488d44010c52f74a
Log link: https://treeherder.mozilla.org/logviewer?job_id=391507527&repo=autoland&lineNumber=8230

Comment 4

[Mark Banner (:standard8)]

Thanks, I've updated the line number to match the file change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0679274d6ed5
Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers

Comment 6

[Marian-Vasile Laza]

Backed out changeset 0679274d6ed5 (Bug 1792398) for causing bc failures on browser_sendQuery.js.
Backout link
Push with failures <--> bc9
Failure Log

Comment 7

[Mark Banner (:standard8)]

Sorry, didn't spot there was two related tests failing the same way. Pushing to try this time.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bce21098fc4
Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8bce21098fc4