1784092 - Set ENABLE_CHANGE_ARRAY_BY_COPY on Nightly

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task)

Description

[André Bargull [:anba]]

Enable ENABLE_CHANGE_ARRAY_BY_COPY on Nightly, because the proposal has reached stage 3, so we should make sure we actually run any tests for the proposal. But don't yet enable "javascript.options.experimental.enable_change_array_by_copy" by default on Nightly, because we still want to wait for https://github.com/tc39/test262/pull/3464 to get more test coverage. (All tests from the test262 PR pass in our current implementation.)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1784092 - Part 1: Remove tests for removed TypedArray.prototype.toSpliced function. r=mgaudet!

Depends on D154266

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1784092 - Part 2: Enable change-array-by-copy build option by default on Nightly. r=mgaudet!

This only enables the build option, which allows to actually run any tests in CI.

Depends on D154267

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1784092 - Part 3: Update test262 importer feature checks. r=mgaudet!

Enable "array-grouping" and "change-array-by-copy" tests.

Depends on D154268

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1784092 - Part 4: Update test262. r=mgaudet!

Update test262 after enabling the features from part 2.

Depends on D154269

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1784092 - Part 5: Update test262 exclusions. r=mgaudet!

Depends on D154270

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8525901a008a
Part 1: Remove tests for removed TypedArray.prototype.toSpliced function. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/43f09ff76a7c
Part 2: Enable change-array-by-copy build option by default on Nightly. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/293b349acef8
Part 3: Update test262 importer feature checks. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b92f9185c00e
Part 4: Update test262. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a8f802732daf
Part 5: Update test262 exclusions. r=mgaudet

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing SM assertion failures on js/Value.h.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a8f802732daf1549c6ba608d0a5d2c30034f661c&selectedTaskRun=LAEWMEHjS8mmCCo0R45Afg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=387128882&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/66e3220110ba0dd99ba7d45684ac4731886a59a9

Comment 8

[André Bargull [:anba]]

Actually a bug from an earlier patch. Filed bug 1784454 to fix it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2ad151091ab
Part 1: Remove tests for removed TypedArray.prototype.toSpliced function. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/48af0bb8fded
Part 2: Enable change-array-by-copy build option by default on Nightly. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/bd3e6a687517
Part 3: Update test262 importer feature checks. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e3ccb790bbc8
Part 4: Update test262. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ae359d13647a
Part 5: Update test262 exclusions. r=mgaudet

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f2ad151091ab
https://hg.mozilla.org/mozilla-central/rev/48af0bb8fded
https://hg.mozilla.org/mozilla-central/rev/bd3e6a687517
https://hg.mozilla.org/mozilla-central/rev/e3ccb790bbc8
https://hg.mozilla.org/mozilla-central/rev/ae359d13647a