1783703 - Fix various issues in the Change-Array-By-Copy functions

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P1)

Description

[André Bargull [:anba]]

Fix various issues in the Change-Array-By-Copy functions and add some optimisations for the C++ code.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 1: Remove ContextOptions::arrayGrouping(). r=mgaudet!

There's already a realm creation option for this feature.

Depends on D153981

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 2: Change-Array-By-Copy flag should be a RealmCreationOptions. r=mgaudet!

Built-ins are created when the realm is created (at least according to the spec),
so it should be a RealmCreationOptions.

Depends on D153982

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 3: Remove TypedArrayProtoFinish. r=mgaudet!

Depends on D153983

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 4: Remove TypedArray.prototype.toSpliced(). r=mgaudet!

This function has been removed from the proposal.

Depends on D153984

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 5: Align TypedArrayToSorted with TypedArraySort. r=mgaudet!

Changes:

• Don't enter the compartment of the TypedArray to match TypedArraySort. This
  is done to avoid having to switch the compartment when the comparator function
  is in the current compartment.
• Add missing check for detached buffers.
• Use single line comments, because we prefer them for new code.
• Avoid unnecessary indirection through CallTypedArrayMethodIfWrapped.

Depends on D153985

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 6: Handle detached buffers in TypedArrayToReversed. r=mgaudet!

Drive-by change:

• Replace DefineDataProperty with assignment to better match spec.

Depends on D153986

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 7: Synchronise and fix some issues in TypedArrayWith. r=mgaudet!

Changes:

• Correctly check for detached buffers.
• Consistently use var.
• Coerce value before the range check.
• Reload length before range check.
• Replace DefineDataProperty with assignment to match spec.
• Remove unused function isValidIntegerIndex

Depends on D153987

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 8: Remove incorrect comment in TypedArrayAt. r=mgaudet!

Depends on D153988

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 9: Fix various issues in array_with. r=mgaudet!

Changes:

• GetPrototypeFromBuiltinConstructor is unnecessary.
• Use NewDensePartlyAllocatedArray to better describe how the array is allocated.
• IsIntegralNumber is unused.
• More comment changes.
• JSMSG_BAD_INDEX doesn't have an argument string.
• int64_t(len + actualIndex) is UB when the result is outside the int64_t range.
• Add missing CheckForInterrupt.
• Use DefineArrayElement instead of SetArrayElement.
• Prefer variable name arr over A to match other functions here and elsewhere in C++.

Depends on D153989

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 10: Clean-up Array.prototype.splice helpers. r=mgaudet!

• Use correct types.
• Use single line comments, because we prefer them in new code.
• Add extra assertions.

Depends on D153990

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 11: Fix various issues in array_toSpliced. r=mgaudet!

Changes:

• array_toSpliced instead of array_to_spliced to match naming conventions.
• More comment changes.
• More assertions.
• Use more narrow types where possible.
• Add missing CheckForInterrupt.
• Use DefineArrayElement instead of SetArrayElement to match spec.

Depends on D153991

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 12: Inline NewDensePartlyAllocatedArray with uint64_t length argument. r=mgaudet!

Needed for later patches.

Depends on D153992

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 13: Add an optimised code path for dense elements to Array.prototype.with. r=mgaudet!

We should provide an optimisation for dense elements when the code is already
in C++.

Depends on D153993

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 14: Add an optimised code path for dense elements to Array.prototype.toSpliced. r=mgaudet!

We should provide an optimisation for dense elements when the code is already
in C++.

Depends on D153994

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1783703 - Part 15: Avoid calling IsArraySpecies twice in array_splice. r=mgaudet!

Depends on D153995

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20bab21cb2f9
Part 1: Remove ContextOptions::arrayGrouping(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/51f5e08c0910
Part 2: Change-Array-By-Copy flag should be a RealmCreationOptions. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/756492ddc26e
Part 3: Remove TypedArrayProtoFinish. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/cc68008df183
Part 4: Remove TypedArray.prototype.toSpliced(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/bf33097e583a
Part 5: Align TypedArrayToSorted with TypedArraySort. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/10e2bccd526b
Part 6: Handle detached buffers in TypedArrayToReversed. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a8624e35aca9
Part 7: Synchronise and fix some issues in TypedArrayWith. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/94f2ccf5ad44
Part 8: Remove incorrect comment in TypedArrayAt. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/62d7d9d37022
Part 9: Fix various issues in array_with. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/dd1820cfa903
Part 10: Clean-up Array.prototype.splice helpers. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b39a39e874ef
Part 11: Fix various issues in array_toSpliced. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ede9a0e515ad
Part 12: Inline NewDensePartlyAllocatedArray with uint64_t length argument. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d3bb893d3ebe
Part 13: Add an optimised code path for dense elements to Array.prototype.with. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c65668216e4e
Part 14: Add an optimised code path for dense elements to Array.prototype.toSpliced. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e54f9ca5cb57
Part 15: Avoid calling IsArraySpecies twice in array_splice. r=mgaudet

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/20bab21cb2f9
https://hg.mozilla.org/mozilla-central/rev/51f5e08c0910
https://hg.mozilla.org/mozilla-central/rev/756492ddc26e
https://hg.mozilla.org/mozilla-central/rev/cc68008df183
https://hg.mozilla.org/mozilla-central/rev/bf33097e583a
https://hg.mozilla.org/mozilla-central/rev/10e2bccd526b
https://hg.mozilla.org/mozilla-central/rev/a8624e35aca9
https://hg.mozilla.org/mozilla-central/rev/94f2ccf5ad44
https://hg.mozilla.org/mozilla-central/rev/62d7d9d37022
https://hg.mozilla.org/mozilla-central/rev/dd1820cfa903
https://hg.mozilla.org/mozilla-central/rev/b39a39e874ef
https://hg.mozilla.org/mozilla-central/rev/ede9a0e515ad
https://hg.mozilla.org/mozilla-central/rev/d3bb893d3ebe
https://hg.mozilla.org/mozilla-central/rev/c65668216e4e
https://hg.mozilla.org/mozilla-central/rev/e54f9ca5cb57