Closed
Bug 1780166
Opened 3 years ago
Closed 3 years ago
esmify fails to migrate browser.js due to nodeFrom.comments being an invalid iterator
Categories
(Core :: XPConnect, defect, P1)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox-esr102 | --- | unaffected |
| firefox102 | --- | unaffected |
| firefox103 | --- | unaffected |
| firefox104 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
I missed this before - esmify is failing to migrate browser.js due to nodeFrom.comments being an invalid iterator. The line is:
nodeTo.comments = [...nodeTo.comments, ...nodeFrom.comments];
In this case, nodeFrom.comments is undefined, so we should skip the comment copying function in that case.
|
Assignee | |
Updated•3 years ago
|
Blocks: esm-ification
|
||
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1779927
status-firefox102:
--- → unaffected
status-firefox103:
--- → unaffected
status-firefox104:
--- → affected
status-firefox-esr102:
--- → unaffected
status-firefox-esr91:
--- → unaffected
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/108b7d5cd94f
When esmify is moving comments, check that comments on the from node exist. r=arai
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•