1779988 - Add ESLint rule that rejects multiple `ChromeUtils.defineESModuleGetters` call on the same object

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Tooru Fujisawa [:arai]]

Related to bug 1779927.

Calling ChromeUtils.defineESModuleGetters multiple times on the same object is not optimal, and ./mach esmify doesn't cover merging all lazy getter calls into one (bug 1779927 adds some coverage, but it doesn't work if there's other statement in between them).

It's better having an ESLint rule that checks multiple ChromeUtils.defineESModuleGetters calls, at the same level (e.g. top-level, without any branch or block), and rejects it, and also possibly merge them with --fix

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779988 - Part 1: Merge multiple ChromeUtils.defineESModuleGetters calls into one. r?Standard8!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779988 - Part 2: Add ESLint rule that rejects multiple `ChromeUtils.defineESModuleGetters` call on the same object. r?Standard8!

Depends on D152879

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b16f2dec7a3
Part 1: Merge multiple ChromeUtils.defineESModuleGetters calls into one. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/9f72ffc8275d
Part 2: Add ESLint rule that rejects multiple `ChromeUtils.defineESModuleGetters` call on the same object. r=Standard8

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/5b16f2dec7a3
https://hg.mozilla.org/mozilla-central/rev/9f72ffc8275d