1779629 - ESMify mozjexl.jsm

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

mozjexl.js / mozjexl.jsm need to be replaced by an ESM module. That file is moving to being generated in https://github.com/mozilla/mozjexl.

I think the fast path here is likely to be to upgrade that repo to a new version of webpack that supports generating ES modules. Or if that turns out to be a pain, switching to rollup or somesuch.

Comment 1

[Mark Banner (:standard8)]

Attachment: GitHub Pull Request

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1779629 - Import latest mozjexl to convert it to a sys.mjs file. r?dmose!

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I'd guess it will make sense to land this as part of bug 1778535.

Comment 4

[Mark Banner (:standard8)]

An alternative here would be to do a "simple" conversion of the existing mozjexl in-tree, i.e. this.mozjexl= -> export var mozjexl =, and strip EXPORTED_SYMBOLS.

This would unblock this bug and esm-ification, though would mean that there would be a couple of extra steps next time an import happened from the repository - however, given that doesn't seem to happen often, maybe that isn't much of an issue.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1779629 - Hand-convert mozjexl.js to an ESM. r?dmose!,Standard8!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c07676719b31
Hand-convert mozjexl.js to an ESM. r=dmose,Standard8

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c07676719b31