1779047 - Adapt mach esmify for comm-central

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Rob Lemley [:rjl]]

mach esmify helps with esmification. As is, it probably isn't too useful for comm-central code.

Comment 1

[Rob Lemley [:rjl]]

Initial notes

The HGUtils class won't handle files in comm/ because it's a nested repo. It's inconvenient, but it's not a problem that hasn't been dealt with before. (Though completing comm-central one-repo project would help a lot here.)

Once HGUtils is hacked up, running ./mach esmify comm/mail completes, but with numerous warnings "Unknown module" warnings during rewrite_imports. That's probably because map.json doesn't list anything from comm-central.

Last, the eslint step needs some adjustment. When ESLint runs in CI, it is run from the comm/ sub-directory like ../mach eslint.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1779047 - mach tb-esmify command. r=#thunderbird-reviewers

This won't work -- too much is relying on the javascript portion
living in /tools/esmify.

Comment 3

[Rob Lemley [:rjl]]

Attachment: WIP: Bug 1779047 - DO NOT COMMIT - Scripts to build map.json file.

Depends on D155870

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36e0a3e4b5bd
mach tb-esmify command. r=aleca

Comment 5

[Magnus Melin [:mkmelin]]

Great job Rob, thanks for getting this going!