1778089 - Improve error information when loading an ESM fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jon Coppeard (:jonco)]

Right now there's little to show what went wrong. This is not a good experience for developers.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1778089 - Part 1: Check the detail of the thrown error in system ESM import failure. r?jonco!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1778089 - Part 2: Report error when mozJSModuleLoader::LoadSingleModuleScript fails. r?jonco!

Depends on D151710

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1778089 - Part 3: Add more test for ChromeUtils.importESModule. r?jonco!

Depends on D151711

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/365ffb7191e5
Part 1: Check the detail of the thrown error in system ESM import failure. r=jonco
https://hg.mozilla.org/integration/autoland/rev/47d34472b3bc
Part 2: Report error when mozJSModuleLoader::LoadSingleModuleScript fails. r=jonco
https://hg.mozilla.org/integration/autoland/rev/04321b7b8cfe
Part 3: Add more test for ChromeUtils.importESModule. r=jonco

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in js/xpconnect/tests/unit/test_bogus_files.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1423a2500d3f12c46cda0104475fd9813442e773

[Push with failures][(https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=IgXY-TfjS2SfM73-fXja6w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=04321b7b8cfe0e34bcf266e36019342310d92cc8&searchStr=xpc)

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9ca32e00a34
Part 1: Check the detail of the thrown error in system ESM import failure. r=jonco
https://hg.mozilla.org/integration/autoland/rev/40c499c59fc6
Part 2: Report error when mozJSModuleLoader::LoadSingleModuleScript fails. r=jonco
https://hg.mozilla.org/integration/autoland/rev/f5a257fc464f
Part 3: Add more test for ChromeUtils.importESModule. r=jonco

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f9ca32e00a34
https://hg.mozilla.org/mozilla-central/rev/40c499c59fc6
https://hg.mozilla.org/mozilla-central/rev/f5a257fc464f