1772930 - Remove osfile.jsm usage from toolkit/components/downloads/

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Description

[Beth Rennie [:beth] (she/her)]

https://searchfox.org/mozilla-central/search?q=osfile.jsm&path=^toolkit%2Fcomponents%2Fdownloads%2F

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/289203a06952
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in dom/system/tests/ioutils/test_ioutils_read_write.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/53d3134566d8bd4c597c403f82d223bc110aee1a

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_read_write.html | TypeError: [...] is not a function - Should not throw any errors

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21b10bf50941
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing multiple failures

Backout link

Push with failures - xpcshell // Failure log - xpcshell

Push with failures 1 - bc // Failure log 1 - bc

Push with failures 2 - bc // Failure log 2 - bc

Push with failures 3 - bc // Failure log 3 - bc

Comment 6

[Mathew Hodson]

I noticed one mistake in common_test_Download.js line 407

await PathUtils.remove(targetFile.path);

It should be IOUtils.remove instead.

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1772930 - Return NS_ERROR_FILE_ALREADY_EXISTS when refusing to overwrite files in IOUtils r?nika

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e712d8f5d3e
Return NS_ERROR_FILE_ALREADY_EXISTS when refusing to overwrite files in IOUtils r=nika
https://hg.mozilla.org/integration/autoland/rev/c194d5143ed4
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7e712d8f5d3e
https://hg.mozilla.org/mozilla-central/rev/c194d5143ed4