Closed Bug 1768022 Opened 3 years ago Closed 3 years ago

Stop using `Cu.getGlobalForObject` to get the shared global

Categories

(Core :: XPConnect, task)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

(Keywords: perf-alert)

Attachments

(1 file)

Some code uses Cu.getGlobalForObject(this) to get the shared global of JSMs, but this can be achieved by globalThis

https://searchfox.org/mozilla-central/search?q=Cu.getGlobalForObject%28this%29%29&path=jsm&case=true&regexp=false

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/cddcdc46d348 Use globalThis instead of Cu.getGlobalForObject(this). r=Standard8,webdriver-reviewers,necko-reviewers,whimboo,kershaw
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

== Change summary for alert #34170 (as of Thu, 19 May 2022 07:13:50 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
14% tumblr FirstVisualChange windows10-64-shippable-qr fission warm webrender 192.93 -> 166.27
13% tumblr FirstVisualChange windows10-64-shippable-qr fission warm webrender 190.25 -> 166.23
5% tumblr ContentfulSpeedIndex windows10-64-shippable-qr fission warm webrender 471.04 -> 445.92
5% tumblr SpeedIndex windows10-64-shippable-qr cold fission webrender 707.96 -> 672.08
5% tumblr PerceptualSpeedIndex windows10-64-shippable-qr cold fission webrender 796.38 -> 757.92
... ... ... ... ...
3% tumblr LastVisualChange windows10-64-shippable-qr fission warm webrender 856.52 -> 833.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34170

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: