1761989 - Remove @@species from InitializeTypedArrayFromTypedArray

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yulia Startsev [:yulia] OOO until July 2026]

https://github.com/tc39/ecma262/issues/2677

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 1: Remove species lookup from InitializeTypedArrayFromTypedArray. r=mgaudet!

Implement the changes from https://github.com/tc39/ecma262/issues/2677 and
https://github.com/tc39/ecma262/pull/2719.

The next patches will perform further clean-ups.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 2: Update spec step references. r=mgaudet!

Depends on D152262

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 3: Remove unused ctor argument from AllocateArrayBuffer. r=mgaudet!

The caller is always passing %ArrayBuffer%, so we can simplify this code a bit.

Depends on D152263

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 4: Remove unused nonDefaultProto argument from maybeCreateArrayBuffer. r=mgaudet!

All callers are passing nullptr for nonDefaultProto.

Depends on D152264

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 5: Remove AllocateArrayBuffer. r=mgaudet!

Remove AllocateArrayBuffer now that it's just an alias for maybeCreateArrayBuffer.

Also replace the no longer needed detached check with a release assertion.

Depends on D152265

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1761989 - Part 6: Remove no longer needed ArrayBuffer reification. r=mgaudet!

The ArrayBuffer was only reified for the ArrayBuffer constructor optimisation
in GetBufferSpeciesConstructor. GetBufferSpeciesConstructor was removed in
part 1, so we no longer need this code, too.

Depends on D152266

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c654e89d5a1a
Part 1: Remove species lookup from InitializeTypedArrayFromTypedArray. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c9020a758adb
Part 2: Update spec step references. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9b6d400760b4
Part 3: Remove unused ctor argument from AllocateArrayBuffer. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/bc53a3e681f8
Part 4: Remove unused nonDefaultProto argument from maybeCreateArrayBuffer. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1e432ca231d6
Part 5: Remove AllocateArrayBuffer. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b3d4c6ee892f
Part 6: Remove no longer needed ArrayBuffer reification. r=mgaudet

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c654e89d5a1a
https://hg.mozilla.org/mozilla-central/rev/c9020a758adb
https://hg.mozilla.org/mozilla-central/rev/9b6d400760b4
https://hg.mozilla.org/mozilla-central/rev/bc53a3e681f8
https://hg.mozilla.org/mozilla-central/rev/1e432ca231d6
https://hg.mozilla.org/mozilla-central/rev/b3d4c6ee892f