1745944 - Use new ChromeUtils.getXPCOMErrorName() method to get platform error names

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1740543 added a new method to retrieve the name of errors as a string of any given XPCOM error code.
Meaning we could get rid of this outdated copy of c++ code we were using over there:
https://searchfox.org/mozilla-central/rev/71befbc9bc348d33f0c7307dc48e3cb36ba78650/devtools/server/actors/network-monitor/utils/network-utils.js#31-551

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1745944 - [devtools] Use new ChromeUtils.getXPCOMErrorName() method to get platform error names.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1745944 - [devtools] Clarify the two tests against ResourceCommand cache for NETWORK_EVENT's.

In this test, there is two that are actually dedicated to cover ResourceCommand internal cache
and the precise behavior of ignoreExistingResources: true/false.

I pulled them off in a dedicated test file and tried to simplified them a bit.

Because the server doesn't really support fetch request done before calling watchResources,
this test is a bit hard to understand. So I tried to make it clear via extensive comments.

Then, my goal is to reuse the third and simplier test to extend the coverage of NETWORK_EVENT
with many other assertions.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1745944 - [devtools] Make browser_resources_network_events.js generic enough to be used for other test pages.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&revision=741350ab6f4a09a99a15babe4c8c9133bffb22d2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f4c55b3bea7
[devtools] Clarify the two tests against ResourceCommand cache for NETWORK_EVENT's. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/10b6a5257630
[devtools] Make browser_resources_network_events.js generic enough to be used for other test pages. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f73088ff3b94
[devtools] Use new ChromeUtils.getXPCOMErrorName() method to get platform error names. r=nchevobbe

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0f4c55b3bea7
https://hg.mozilla.org/mozilla-central/rev/10b6a5257630
https://hg.mozilla.org/mozilla-central/rev/f73088ff3b94