1740236 - WPT failures in /css/css-grid/grid-items/aspect-ratio-004.html

Status: NEW

(Core :: Layout: Grid, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 31547 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-grid/grid-items/aspect-ratio-005.html: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1740115 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 2

[Thomas Wisniewski [:twisniewski]]

It seems that all of these related tests fail now, aspect-ratio-001.html to aspect-ratio-005.html:

• https://wpt.fyi/results/css/css-grid/grid-items/aspect-ratio-001.html
• https://wpt.fyi/results/css/css-grid/grid-items/aspect-ratio-002.html
• https://wpt.fyi/results/css/css-grid/grid-items/aspect-ratio-003.html
• https://wpt.fyi/results/css/css-grid/grid-items/aspect-ratio-004.html
• https://wpt.fyi/results/css/css-grid/grid-items/aspect-ratio-005.html

Comment 3

[Thomas Wisniewski [:twisniewski]]

These failures also seem related:

• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-002.html

Comment 4

[Boris Chiou [:boris]]

This is pretty similar with Bug 1719273, which also has a percentage height on the grid idem, with aspect-ratio.

Comment 5

[Boris Chiou [:boris]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #3)

These failures also seem related:

• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-002.html

After the quick check for these two failures, I filed Bug 1865438 for them because I think they have a different root cause.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

aspect-ratio-[001-003,005].html are fixed by bug 1944423.

aspect-ratio-004.html still needs investigation:

<div style="display: inline-grid; grid-template-rows: 100px; background: green;">
  <img src="support/50x50-green.png" style="align-self: stretch; opacity: 0;">
</div>

The test expects the item's block size (stretched via align-self: stretch) to transfer to the inline axis, contributing to the grid container's intrinsic inline size.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per comment 6, the only test failure at the moment is aspect-ratio-004.html.