1734056 - Remove some remaining pref-related plugin cruft

Status: RESOLVED MOVED

(Core :: General, task)

Description

[Andrew McCreight [:mccr8]]

I came across a few things related to plugins that don't seem to do anything any more, and can probably be removed. There are a few places setting prefs that don't do anything more.

The prefs I found are

• dom.ipc.plugins.sandbox-level.flash
• dom.ipc.plugins.sandbox-level.default
• dom.ipc.plugins.enabled
• plugin.disable

Comment 1

[Andrew McCreight [:mccr8]]

There's also a bunch of other dom.ipc.plugins.* stuff that maybe could be removed: https://searchfox.org/mozilla-central/search?q=dom.ipc.plugins&path=

Comment 2

[Thorin [:thorin]]

from Bug 1714549 (which I'll close as a duplicate)

AFAICT these do nothing anymore

• dom.ipc.plugins.flash.subprocess.crashreporter.enabled
• dom.ipc.plugins.reportCrashURL - see Bug 1554089
• plugin.state.flash
• security.mixed_content.block_object_subrequest ? was this flash only?

Not sure on these ones, there may be others

• dom.ipc.plugins.flash.disable-protected-mode ?
• plugins.flashBlock.enabled ?
• urlclassifier.flash* ?

Comment 4

[Chris Peterson [:cpeterson]]

There are also some browser.flash-protected-mode-flip.* prefs (and a _handleFlashHang() function in BrowserGlue.jsm) that can probably be removed:

https://searchfox.org/mozilla-central/rev/1e7f7235cf822e79cd79ba9e200329ede3d37925/browser/app/profile/firefox.js#1186-1190

https://searchfox.org/mozilla-central/rev/1e7f7235cf822e79cd79ba9e200329ede3d37925/browser/components/BrowserGlue.jsm#4369-4426

And unused strings for flashHang and flashActivate notifications:

https://searchfox.org/mozilla-central/rev/1e7f7235cf822e79cd79ba9e200329ede3d37925/browser/locales/en-US/chrome/browser/browser.properties#845-848

https://searchfox.org/mozilla-central/rev/1e7f7235cf822e79cd79ba9e200329ede3d37925/browser/locales/en-US/chrome/browser/browser.properties#291-299

Comment 5

[Thorin [:thorin]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

There are also ...

and can someone close Bug 372097 , thanks :)

Comment 6

[Julian Descottes [:jdescottes]]

The plugins.favorfallback were also related to flash and don't seem used anymore: https://searchfox.org/mozilla-central/search?q=plugins.favorfallback&path=&case=true&regexp=false

Comment 7

[Jim Mathies [:jimm]]

This needs to get broken out into individual bugs based on where the code is. Moving to core general for now to keep it around. The Plug-Ins component is going away.

Comment 8

[Jim Mathies [:jimm]]

dom.ipc.plugins.* -
Bug 1769601 - Remove obsolete dom.ipc.plugin.* related pref breadcrumbs

flashPluginState -
Bug 1769602 - Remove old Flash references in netwerk code

browser -
Bug 1769603 - Remove old plugin / flash references from browser code