Closed Bug 1725287 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30002 - Highlight API: Invalidate markers' nodes in prepaint phase

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30002 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30002
Details from upstream follow.

b'Fernando Fiori <ffiori@microsoft.com>' wrote:

Highlight API: Invalidate markers' nodes in prepaint phase

Move HighlightRegistry::ValidateHighlightMarkers calls to prepaint phase
so the nodes affected by the markers added/removed are invalidated and
then repainted in the paint phase of this lifecycle.

Also make tests wait until callback is executed.

Bug: 1238845
Change-Id: I998af8632ba21c7c504c99290a3424be7537c569
Reviewed-on: https://chromium-review.googlesource.com/3088068
WPT-Export-Revision: 5e0f19eedb79637f28e335b88bfa8a80a1d3be6f

PR 30002 applied with additional changes from upstream: 0f94ca65282ba94a40f7d28f704a90aa5dce93e5
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests

Status Summary

Firefox

TIMEOUT: 10

Chrome

PASS : 3
FAIL : 7

Safari

TIMEOUT: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/painting/custom-highlight-painting-invalidation-001.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-002.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-003.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-004.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-005.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-006.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-staticrange-004.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-staticrange-005.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-staticrange-006.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/css/css-highlight-api/painting/custom-highlight-painting-staticrange-007.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4956920a8c6 [wpt PR 30002] - Highlight API: Invalidate markers' nodes in prepaint phase, a=testonly https://hg.mozilla.org/integration/autoland/rev/a565040bfbaa [wpt PR 30002] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f4956920a8c6
https://hg.mozilla.org/mozilla-central/rev/a565040bfbaa

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.