1724299 - Implement auto-expanding <details>

Status: RESOLVED FIXED

(Core :: Find Backend, enhancement, P3)

Description

[Joey Arhar]

In this HTML spec PR, we are making <details> automatically expand for element fragments and find-in-page: https://github.com/whatwg/html/pull/6466
This way, the user can effectively use find-in-page to search for content hidden inside <details> elements without having to manually expand all of them first.
In order to make it performant, the spec PR also suggests using content-visibility:hidden inside <details>'s user agent shadowdom instead of "removing the slot from the rendering" when <details> are closed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
Thank you for opening this enhancement. I will set this as New and waiting for the developers opinion about it.

Thanks for your input.

Comment 3

[Drew Willcoxon :adw]

Not sure whether this belongs in Find Toolbar or Core, but auto-expanding when the find toolbar is used sounds like more of the former...

Comment 4

[Bill Goldstein [:aja] (UTC-6)]

FYI: This is now shipping in Chrome.
From Chrome 97 announcement at https://blog.chromium.org/2021/11/chrome-97-webtransport-new-array-static.html

"Auto-expand Details Elements

Closed details elements are now searchable and can now be linked to. These hidden elements will also automatically expand when find-in-page, ScrollToTextFragment, and element fragment navigation are used."

Comment 7

[Jim Lewis]

Currently works in both Chrome and Edge

For EDA log files that are 180K lines long, using <summary>/<details> to hide information is important. Yet when our build summary report (similar to a JUnit test report) shows that a test failed, we need to be able to quickly go to the log information for that test failure. Putting the link inside of the <details> allows us to jump to the appropriate place and provide the detailed information.

Comment 10

[max]

Expandable on search <details> are recommended from the standpoint of accessibility
https://fosdem.org/2023/schedule/event/a11y_eaa_bfsg_wcag_wai_aria_wtf/

Comment 15

[Tom S. (please needinfo tschuster)]

Can we get a priority for this?

Comment 16

[Sean Feng [:sefeng211]]

Not sure what a priority would do here...however I think this is likely an P3 and we probably needs more discussions about allocating resources to fix the feature gaps for <details>.

Comment 17

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This failure is part of interop-2025 scope.

Comment 18

[Michal Čaplygin [:myf]]

Since it relates to Text Fragments, this issue (also) probably blocks meta bug 1753933 (?)

Comment 19

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1724299, part 1 - Implement auto-expanding details. r=emilio!

Comment 20

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1724299, part 2 - Fixed Text-Fragment related web-platform tests for auto-expanding details. r=emilio!

beforematch is not fired for auto-expanding details,
neither is it used in the target page.
The test ensures that the page scrolls as a result of
scrolling to an auto-expanding details element using
a text fragment navigation.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33fb6d7456da
part 1 - Implement auto-expanding details. r=emilio
https://hg.mozilla.org/integration/autoland/rev/65d1ba19afbf
part 2 - Fixed Text-Fragment related web-platform tests for auto-expanding details. r=emilio

Comment 22

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51791 for changes under testing/web-platform/tests

Comment 23

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/33fb6d7456da
https://hg.mozilla.org/mozilla-central/rev/65d1ba19afbf

Comment 24

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 25

[Jan Jaeschke [:jjaschke]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This allows find-in-page to search in closed <details> elements and opens them if the search string is found.
[Affects Firefox for Android]: yes
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx139 relnotes.