1713886 - Replace `fission` annotation with `webrender` in accessible/tests/browser/events/browser.ini

Status: RESOLVED DUPLICATE of bug 1714067

(Core :: Disability Access APIs, task)

Description

[Andrew Halberstadt [:ahal]]

The following tests were disabled in accessible/tests/browser/events/browser.ini due to new Fission platform triage:
browser_test_scrolling.js
browser_test_selection_urlbar.js

Full diff:

--- a/accessible/tests/browser/events/browser.ini
+++ b/accessible/tests/browser/events/browser.ini
@@ -5,19 +5,23 @@ support-files =
   !/accessible/tests/mochitest/*.js
   !/accessible/tests/browser/*.jsm
 environment = 
   A11YLOG=doclifecycle,events,notifications
 
 [browser_test_docload.js]
 skip-if = e10s
 [browser_test_scrolling.js]
+skip-if =
+  fission && os == "win" && !debug  # New platform triage
 [browser_test_textcaret.js]
 [browser_test_focus_browserui.js]
 [browser_test_focus_dialog.js]
 [browser_test_focus_urlbar.js]
 skip-if =
   os == 'win' && os_version == '10.0' && webrender # Bug 1492259
 [browser_test_A11yUtils_announce.js]
 [browser_test_selection_urlbar.js]
+skip-if =
+  fission && os == "win" && ! debug  # New platform triage
 [browser_test_panel.js]
 skip-if =
   os == 'win' && os_version == '10.0' && webrender # Bug 1703620

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 accessible/tests/browser/events/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

Comment 1

[Chris Peterson [:cpeterson]]

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Comment 2

[Andrew Halberstadt [:ahal]]

Looks like the browser_test_scrolling.js failure was recently disabled on all Windows platform in bug 1636476 (so not fission specific). I'll remove that annotation.

I'll leave the bug open for browser_test_selection_urlbar.js.

Comment 3

[James Teh [:Jamie]]

(In reply to Andrew Halberstadt [:ahal] from comment #2)

I'll leave the bug open for browser_test_selection_urlbar.js.

I don't see that one in the try run linked above either. Do you have a link to a try run where you saw that fail? Otherwise, I can just try with it enabled and see what happens...

Comment 4

[James Teh [:Jamie]]

I pushed my own try run and I didn't get a failure there either. (I didn't need to remove the skip line because your patch isn't in central yet.) Is there something I'm missing here or can this be closed?

Comment 5

[James Teh [:Jamie]]

(In reply to Andrew Halberstadt [:ahal] from comment #2)

I'll leave the bug open for browser_test_selection_urlbar.js.

Ah. I wonder if you were seeing bug 1714067, which seems to be Webrender (but not Fission) specific.

Comment 6

[Andrew Halberstadt [:ahal]]

(In reply to James Teh [:Jamie] from comment #5)

(In reply to Andrew Halberstadt [:ahal] from comment #2)

I'll leave the bug open for browser_test_selection_urlbar.js.

Ah. I wonder if you were seeing bug 1714067, which seems to be Webrender (but not Fission) specific.

Yeah, that's pretty likely. I was using Push Health and made some mistakes due to a bug there.

Your try push didn't run the fission tasks because my series was what was turning them on in the first place. If you like we can remove the annotation here and let it get treated as a normal intermittent the same as with webrender.

Comment 7

[James Teh [:Jamie]]

Yeah, I think we should remove this annotation and treat it as a Webrender intermittent. Meanwhile, despite hours of investigation, I still have no idea what's causing those Webrender intermittents... 😩

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to James Teh [:Jamie] from comment #7)

Yeah, I think we should remove this annotation and treat it as a Webrender intermittent. Meanwhile, despite hours of investigation, I still have no idea what's causing those Webrender intermittents... 😩

Sounds like we can change the annotation like:

 [browser_test_selection_urlbar.js]
 skip-if =
-  fission && os == "win" && !debug  # Bug 1713886 - new Fission platform triage
+  webrender && os == "win" && !debug  # Bug 1714067

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/accessible/tests/browser/events/browser.ini#22-24

AFAIK, we only never run this test with Fission enabled but WebRender disabled, so replacing this fission annotation with webrender would make no difference for Fission's test coverage. As long as this is a WebRender bug, I don't think this bug to replace the annotation needs to block shipping Fission MVP. The WebRender bug is still important, of course. :)

Comment 9

[Andrew Halberstadt [:ahal]]

This test is being disabled on all Windows platforms (even non-webrender) in bug 1714067. So I'll just dupe there. I've asked the sheriffs to remove this annotation as part of their patch over there.