1712862 - New wpt failures in /css/css-grid/alignment/grid-baseline-align-cycles-001.html

Status: NEW

(Core :: Layout: Grid, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 29106 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-grid/alignment/grid-baseline-align-cycles-001.html: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1712826 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Daniel Holbert [:dholbert]]

wpt.fyi: https://wpt.fyi/results/css/css-grid/alignment/grid-baseline-align-cycles-001.html
wpt.live:
http://wpt.live/css/css-grid/alignment/grid-baseline-align-cycles-001.html
http://wpt.live/css/css-grid/alignment/references/grid-baseline-align-cycles-001-ref.html

Our failure is a mismatch in chunk 3/4 in the first row. We render the two black boxes side-by-side there, when the test is expecting the right black box (and the cyan box below it) to be rendered at a higher position.

Safari fails the test too, but for a different reason; they have a very minor alignment issue that affects the whole test (but otherwise seem to render the testcase and reference case the same).

Comment 2

[Daniel Holbert [:dholbert]]

This isn't a precise diagnosis, just an observation: if I remove align-content:baseline from that 3rd grid container in the first row, OR if I add contain:layout to its rightmost grid item, then the rendering changes to match the expectation in the reference case.

So this is a case where we're using the real baseline when the test is expecting us to synthesize one, it looks like. (I haven't looked closely enough to know if this is a test bug or a Firefox bug, though. I do recall that other browsers didn't implement align-content:baseline at all for a while, so it wouldn't surprise me if this test just inadvertently expected it to have no effect due to having been written in another browser.)

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)

This isn't a precise diagnosis, just an observation: if I remove align-content:baseline from that 3rd grid container in the first row, OR if I add contain:layout to its rightmost grid item, then the rendering changes to match the expectation in the reference case.
[...]
I do recall that other browsers didn't implement align-content:baseline at all for a while,

This is still the case, FWIW (Chromium's bug on align-content: baseline is https://issues.chromium.org/issues/41344054

For this reason, Tiaan and I don't think it makes sense to consider this one a priority for us for real-world grid interoperability.

(I haven't looked closely enough to know if this is a test bug or a Firefox bug, though.)

ni=me to circle back and determine this.