1700909 - Pass `commands` instead of `descriptorFront` to Toolbox constructor

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Now that commands own both DevToolsClient and Descriptor Front, this should be the one object instantiated by gDevTools and passed to the Toolbox.
Bug 1699200 refactored most of the places where we were instantiating a Descriptor Front, but we would need a dedicated work to convert gDevTools and the Toolbox codes.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700909 - [devtools] Migrate gDevTools.showToolbox from descriptor to commands.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront.

Instead we should we querying Toolbox.commands.descriptorFront.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700909 - [devtools] Migrate TabDescriptorFactory to LocalTabCommandsFactory.

Also move iKnownTab to gDevTools.hasToolboxForTab as it feel more natural.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700909 - [devtools] Migrate descriptorFromURL to commandsFromURL.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700909 - [devtools] Migrate DescriptorMixin.shouldCloseClient to Commands.

Note that this depends on the following patch, in order to destroy commands from the toolbox.
Commands have always been destroying the related client. This was a significant simplification in test.
So that I had to reverse the default value of shouldCloseClient and only toggle it to false
where it is strictly needed. Ideally only for about:debugging toolboxes (and two tests).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dbeffe25878
[devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e53aaf8ffe5b
[devtools] Migrate TabDescriptorFactory to LocalTabCommandsFactory. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6f6fe066fc38
[devtools] Migrate descriptorFromURL to commandsFromURL. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/998c0ec4f9d3
[devtools] Migrate DescriptorMixin.shouldCloseClient to Commands. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9bc3e4820f59
[devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser_ext_addon_debugging_netmonitor.js
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VLciWbvUQS6tMLnkOAFEMw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9bc3e4820f59f5262d3f5ac6a61e3e03ad5c24df
Failure log: https://treeherder.mozilla.org/logviewer?job_id=391800643&repo=autoland&lineNumber=3064
Backout: https://hg.mozilla.org/integration/autoland/rev/d9b6974f99e62aae50584d4a46290d787111d86d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c49eab385e1c
[devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/4e6312ea547a
[devtools] Migrate TabDescriptorFactory to LocalTabCommandsFactory. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/67b12d0e350b
[devtools] Migrate descriptorFromURL to commandsFromURL. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5a6b15eb1e12
[devtools] Migrate DescriptorMixin.shouldCloseClient to Commands. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a49f15f66ed4
[devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes,extension-reviewers,willdurand

Comment 9

[Cristian Tuns]

Backed out for causing mochitest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck | default 4642149 bytes leaked (AbstractWatcher, AnimationTimeline, AsyncFreeSnowWhite, AtomSet, Attr, ...)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e22436436df
[devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/07a670f05d5c
[devtools] Migrate TabDescriptorFactory to LocalTabCommandsFactory. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/725d7c635e8c
[devtools] Migrate descriptorFromURL to commandsFromURL. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/377777880120
[devtools] Migrate DescriptorMixin.shouldCloseClient to Commands. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/94859d04ddaf
[devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes,extension-reviewers,willdurand

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2e22436436df
https://hg.mozilla.org/mozilla-central/rev/07a670f05d5c
https://hg.mozilla.org/mozilla-central/rev/725d7c635e8c
https://hg.mozilla.org/mozilla-central/rev/377777880120
https://hg.mozilla.org/mozilla-central/rev/94859d04ddaf