1694912 - Crash in [@ OOM | large | mozalloc_abort | dwrote::glyph_run_analysis::GlyphRunAnalysis::create_alpha_texture]

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect)

Description

[Pascal Chevrel:pascalc]

Crash report: https://crash-stats.mozilla.org/report/index/a38a23f2-c166-4f46-81f4-4d2e50210225

MOZ_CRASH Reason: MOZ_CRASH()

Top 10 frames of crashing thread:

0 mozglue.dll mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:33
1 mozglue.dll mozalloc_handle_oom memory/mozalloc/mozalloc_oom.cpp:51
2 xul.dll gkrust_shared::oom_hook::hook toolkit/library/rust/shared/lib.rs:134
3 xul.dll std::alloc::rust_oom ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/std/src/alloc.rs:330
4 xul.dll alloc::alloc::__alloc_error_handler::__rg_oom ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/alloc/src/alloc.rs:409
5 xul.dll __rust_alloc_error_handler 
6 xul.dll dwrote::glyph_run_analysis::GlyphRunAnalysis::create_alpha_texture third_party/rust/dwrote/src/glyph_run_analysis.rs:93
7 xul.dll webrender::glyph_rasterizer::{{impl}}::flush_glyph_requests::process_glyph gfx/wr/webrender/src/glyph_rasterizer/mod.rs:154
8 xul.dll rayon::iter::plumbing::bridge_producer_consumer::helper<rayon::slice::IterProducer<webrender::glyph_rasterizer::GlyphKey>, rayon::iter::map::MapConsumer<rayon::iter::collect::consumer::CollectConsumer<webrender::glyph_rasterizer::GlyphRasterJob>, closure-0>> third_party/rust/rayon/src/iter/plumbing/mod.rs:438
9 xul.dll rayon_core::job::{{impl}}::execute<rayon_core::latch::SpinLatch, closure-0, rayon::iter::collect::consumer::CollectResult<webrender::glyph_rasterizer::GlyphRasterJob>> third_party/rust/rayon-core/src/job.rs:119

Comment 1

[Jim Blandy :jimb]

The crashes start to pick up on Feb 23, when Firefox 86 was released. Given that and the mention of create_alpha_texture, I wonder if this isn't related to Bug 1687554, even though that was for Android and these crashes are Windows.

https://crash-stats.mozilla.org/signature/?signature=OOM%20%7C%20large%20%7C%20mozalloc_abort%20%7C%20dwrote%3A%3Aglyph_run_analysis%3A%3AGlyphRunAnalysis%3A%3Acreate_alpha_texture&date=%3E%3D2020-09-02T20%3A14%3A00.000Z&date=%3C2021-03-02T20%3A14%3A00.000Z#graphs

Comment 2

[Jamie Nicol [:jnicol]]

Bug 1687554 did affect all platforms, not just Android. However, it doesn't affect anything at this level of the stack. We still rasterize glyphs in exactly the same way, but now we convert them to A8 format after rasterization here. (A few lines later in flush_glyph_requests() than the backtrace). So I'm afraid it'll be due to something else.

Comment 3

[Wayne Mery (:wsmwk)]

zero crashes for 90, 91, 92. Is it gone, or Has the signature changed?
https://crash-stats.mozilla.org/signature/?signature=OOM%20%7C%20large%20%7C%20mozalloc_abort%20%7C%20dwrote%3A%3Aglyph_run_analysis%3A%3AGlyphRunAnalysis%3A%3Acreate_alpha_texture&date=%3E%3D2021-07-04T03%3A57%3A00.000Z&date=%3C2021-10-04T03%3A57%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#graphs

Comment 4

[Jim Mathies [:jimm]]

(In reply to Wayne Mery (:wsmwk) from comment #3)

zero crashes for 90, 91, 92. Is it gone, or Has the signature changed?

Not sure, can't find anything related that's still showing up in large numbers.

https://crash-stats.mozilla.org/search/?signature=~create_alpha_texture&product=Firefox&date=%3E%3D2021-10-04T19%3A31%3A00.000Z&date=%3C2021-10-11T19%3A31%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.