1691334 - On Android, video playback is cropped in fullscreen mode.

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect, P3)

Description

[Petru-Mugurel Lingurar [:petru]]

From github: https://github.com/mozilla-mobile/fenix/issues/17895.

Re-opening because I think this is not the same as issue #8252. Attached a video to show that the video is still at the same aspect ratio and not zoomed in prior to entering fullscreen mode and yet the captions are disappearing everytime I enter fullscreen mode.

https://user-images.githubusercontent.com/73644544/107177570-17b83780-6a0d-11eb-9d26-1c51b5bfaf81.mp4

You can see the same line at the foot on the bottom part of the video and same the creases at the top part of the video on both fullscreen mode and not.

Steps to reproduce

1. Watch any video and enable captions.
2. Go fullscreen mode.

Expected behavior

Captions will still show in fullscreen mode.

Actual behavior

Captions disappearing in fullscreen mode, but will show when you exit fullscreen mode.

Device information

• Device vendor / model and Android version: Mi 9T Pro / MIUI 12
• Firefox for Android version: Nightly (Build #2015791019)

Change performed by the Move to Bugzilla add-on.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

I tested with https://www.youtube.com/watch?v=cabINGswscs on a 20:9 device on the latest GeckoView.

• The videoprogress bar appears as expected
• The fullscreen landscape video is visibly cropped.
• Captions do not appear

I think the main issue is that the video is not properly lay out in the available space.

Comment 2

[Alastor Wu [:alwu]]

That's Youtube issue, they didn't use our webvtt player, they display subtitles by their own VTT player. A lot of HTML players have their own VTT implementation, which involves from parsing cues content to displaying cues.

Only when websites are using our default video control, then the issue would be put on Firefox. I will report this issue to them via our internal contact.

Comment 3

[Alastor Wu [:alwu]]

For example, in this case, the subtitle is displayed via our vtt player, which would still show even if video is in the fullscreen.

Comment 4

[Alastor Wu [:alwu]]

Hmm, no, I think the subtitle is still showing, but the problem is that the video showed in an incorrect ratio. As Petru said in the comment1, the video gets cropped, where the subtitles actually displayed.

Comment 5

[Alastor Wu [:alwu]]

That also happens on a normal video using our default video player, like the case mentioned in comment3. When the video entered the fullscreen, it didn't being displayed correctly, I had to drag the video manually in order to see full video.

Comment 6

[Alastor Wu [:alwu]]

I feel that we should put more attention on this bug, because this cause users being not able to watch fullscreen videos on Android correctly. Agi, how do you feel about this? Do we need to put this on GeckoView's bug tracking list?
Thank you.

Comment 7

[Alastor Wu [:alwu]]

Emilio, I wonder if this bug is related with bug1696717? Thank you.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

This is a youtube issue, see this. I contacted them in the partner list about a week ago.

Comment 9

[Alastor Wu [:alwu]]

But I also found that this issue is not just about video on Youtube, it also happens on videos using our default video control, eg. this. But that might be a different issue, I will wait your patch landing on Fenix Nightly to see if this issue still exists.

When I put a normal video on the fullscreen, I can see that the video isn't put in the right position, I need to scroll it manually to see the whole video. When you put that in PIP mode (fullscreen, then put the app to background), then the video would be cropped super super seriously.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Yeah, that one is in fact bug 1696717.

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

I agree this is important, although there's nothing GeckoView related in this. Let me know how we can help.

Comment 12

[Alastor Wu [:alwu]]

Because today's Firefox Nightly Android is based on 03/08 17:04, so it seems not including the fix in bug 1696717 yet. (the issue still exists for normal video part) I will try it again tomorrow.

For Youtube issue, I saw that Peter Saint-Andre has poked them on the mailing thread, so we still need to wait until Youtube side fixs the problem.

Comment 13

[Alastor Wu [:alwu]]

On today's Nightly, the normal video playback in fullscreen is still the same, it won't show the whole content and requires manaully adjustment. (so it seems the issue is not related with layout, bug 1696717)
PIP on normal video is still seriously broken, but surprisingly it works well on Youtube video (?!)

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Yesterday's nightly had a GeckoView that was a week old. Latest nightly does have mypatch, and seems to work for me, can you confirm?

Comment 15

[Alastor Wu [:alwu]]

Ah awesome! now I can see the fullscreen video is playing in a correct ratio, and the PIP video is also working well. Thank you very much.