1683648 - Remove unused pluginHelp-16.png and contentPluginDisabled.png

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Tim Nguyen :ntim]

These look completely unused:

toolkit/themes/shared/plugins/contentPluginDisabled.png
toolkit/themes/osx/global/plugins/pluginHelp-16.png
toolkit/themes/windows/global/plugins/pluginHelp-16.png

Running hg remove on those files and making a patch should be enough.

Comment 1

[Sonia Singla :soniasingla]

Attachment: Bug 1683648 - Remove unused pluginHelp-16.png and contentPluginDisabled.png. r=ntim

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f1967bdcd23
Remove unused pluginHelp-16.png and contentPluginDisabled.png. r=ntim

Comment 3

[Masatoshi Kimura [:emk]]

Why browser_all_files_referenced.js didn't catch this?

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3f1967bdcd23

Comment 5

[Tim Nguyen :ntim]

(In reply to Masatoshi Kimura [:emk] from comment #3)

Why browser_all_files_referenced.js didn't catch this?

This is because these are files not packaged in jar.mn or moz.build or such. The test you mentioned only catches resource:// or chrome:// unused files to reduce binary size. Sylvestre, is there any bug covering non-packaged unused files? This seems feasible with a whitelist of allowed files.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I don't think so. Is that common?

Comment 7

[Tim Nguyen :ntim]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #6)

I don't think so. Is that common?

It's fairly common after large code removals/refactors that unreferenced files are left around, mainly because this is quite hard to do catch in large code changes.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

OK, if you have an idea on how to automate this detection, please open a new bug :)