1683226 - Get rid of plugin support of IME/keyboard handling

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Before creating automated test framework for native IME handlers, I'd like to drop unused path for plugins.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 1: Make `IMEState::Enabled` an enum class r=m_kato!

Before deleting IMEState::Enabled::PLUGIN, let's make it an enum class
for making the change safer. Almost all of this change is done by
"replace" of VSCode.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 2: Make `HTMLEmbedElement` and `HTMLObjectElement` stop overriding `nsIContent::GetDesiredIMEState()` r=smaug!

Currently, they are never focusable when its type is "plugin".
So, making stop them returning IMEEnabled::Plugin won't change
anything, but it guarantees that nobody will see IMEEnabled::Plugin
at runtime. This is a preparation for the following patches.

Depends on D100100

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 3: Get rid of pathes for handling plugin from `IMEStateManager`, `IMEContentObserver` and `ContentEventHandler` r=smaug!

Depends on D100101

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 4: Make stop `ContentCache` check whether a plugin has focus or not r=m_kato!

Depends on D100102

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 5: Get rid of the path setting candidate window position from plugin on Windows r=m_kato!

Depends on D100103

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 6: Get rid of the path of `DefaultProcOfPluginEvent` r=m_kato!

Depends on D100117

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 7: Get rid of remaining all IMM message handlers for plugin r=m_kato!

Depends on D100118

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 8: Make `IMEHandler` on Windows stop handling plugin cases r=m_kato!

Depends on D100119

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 9: Get rid of `nsIWidget::PluginHasFocus()` r=m_kato!

It's used only by IMM and keyboard handlers on Windows.

Depends on D100120

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 10: Get rid of `nsIWidget::EnableIMEForPlugin()` r=m_kato!

This is used only on Windows.

Depends on D100121

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 11: Get rid of `IMEEnabled::Plugin` r=m_kato!

Depends on D100122

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87c164e0c093
part 1: Make `IMEState::Enabled` an enum class r=m_kato,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/bdcbb8d22b91
part 2: Make `HTMLEmbedElement` and `HTMLObjectElement` stop overriding `nsIContent::GetDesiredIMEState()` r=smaug
https://hg.mozilla.org/integration/autoland/rev/e39ed1138976
part 3: Get rid of pathes for handling plugin from `IMEStateManager`, `IMEContentObserver` and `ContentEventHandler` r=smaug

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c47e25d063f
part 4: Make stop `ContentCache` check whether a plugin has focus or not r=m_kato
https://hg.mozilla.org/integration/autoland/rev/78c4b82a3015
part 5: Get rid of the path setting candidate window position from plugin on Windows r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8f2595f0dfda
part 6: Get rid of the path of `DefaultProcOfPluginEvent` r=m_kato

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/172084df9b2b
part 7: Get rid of remaining all IMM message handlers for plugin r=m_kato

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72421ad7ff7b
part 8: Make `IMEHandler` on Windows stop handling plugin cases r=m_kato

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/87c164e0c093
https://hg.mozilla.org/mozilla-central/rev/bdcbb8d22b91
https://hg.mozilla.org/mozilla-central/rev/e39ed1138976
https://hg.mozilla.org/mozilla-central/rev/0c47e25d063f
https://hg.mozilla.org/mozilla-central/rev/78c4b82a3015
https://hg.mozilla.org/mozilla-central/rev/8f2595f0dfda

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9db4cd3d89
part 9: Get rid of `nsIWidget::PluginHasFocus()` r=m_kato

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3ddd7384de2
part 10: Get rid of `nsIWidget::EnableIMEForPlugin()` r=m_kato

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af42b96cd2b8
part 11: Get rid of `IMEEnabled::Plugin` r=m_kato

Comment 20

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/172084df9b2b
https://hg.mozilla.org/mozilla-central/rev/72421ad7ff7b
https://hg.mozilla.org/mozilla-central/rev/2c9db4cd3d89

Comment 21

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d3ddd7384de2
https://hg.mozilla.org/mozilla-central/rev/af42b96cd2b8

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 12: Get rid of `nsIWidget::SetPluginFocus()` r=m_kato!

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 13: Get rid of `nsIWidget::StartPluginFocused()` r=m_kato!

Depends on D100386

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 14: Get rid of `ComplexTextInputPanel` r=m_kato!

It's used only for a placeholder of composition string in plugins.

Depends on D100387

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 15: Get rid of plugin specific members of `WidgetKeyboardEvent` r=m_kato!,smaug!

Depends on D100388

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1683226 - part 16: Get rid of `WidgetPluginEvent` r=smaug!

Depends on D100389

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b6c96d212f4
part 12: Get rid of `nsIWidget::SetPluginFocus()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6ec93ada1e62
part 13: Get rid of `nsIWidget::StartPluginFocused()` r=m_kato,ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/bc1cc01f5898
part 14: Get rid of `ComplexTextInputPanel` r=m_kato

Comment 28

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4b6c96d212f4
https://hg.mozilla.org/mozilla-central/rev/6ec93ada1e62
https://hg.mozilla.org/mozilla-central/rev/bc1cc01f5898

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a43143cd7a24
part 15: Get rid of plugin specific members of `WidgetKeyboardEvent` r=m_kato,smaug
https://hg.mozilla.org/integration/autoland/rev/64e6fc7cfaeb
part 16: Get rid of `WidgetPluginEvent` r=smaug

Comment 30

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a43143cd7a24
https://hg.mozilla.org/mozilla-central/rev/64e6fc7cfaeb