1669968 - [meta] Stop using lodash in the debugger codebase

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Julian Descottes [:jdescottes]]

lodash is a huge dependency in the debugger (16K lines), and seems to be mostly used for simple helpers. https://searchfox.org/mozilla-central/search?q=lodash&path=debugger%2Fsrc%2F&case=false&regexp=false

The goal of this meta is to stop using lodash. It can be done file by file, or method by method. When trying to replace a lodash import, we should also take the opportunity to review if the usage really makes sense before porting the lodash helper.

The complete list of lodash methods is:

• debounce
• difference
• escapeRegExp
• findIndex
• findLastIndex
• flatMap
• flatten
• flattenDeep
• fromPairs
• groupBy
• has
• isEmpty
• isEqual
• kebabCase
• memoize
• move
• omit
• pullAt
• range
• remove
• sortBy
• throttle
• times
• toPairs
• union
• uniq
• uniqBy
• without
• zip

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:Honza, maybe it's time to close this bug?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, we were discussing this recently. Are there any specific bugs we could add as dependencies?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #2)

Nicolas, we were discussing this recently. Are there any specific bugs we could add as dependencies?

I don't think if we have such bug, we'd have to file them individually.
IMO we could file individual bugs to remove specific lodash method, as it would be easier for someone to tackle such task (instead of doing it file by file, where you might have to deal with different methods)

I'll try to file some

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

We should have the full list of blocker bugs now

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1669968 - [devtools] Remove lodash from tree.r=ochameau.

Depends on D136172

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da79de368bfa
[devtools] Remove lodash from tree.r=ochameau.

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/da79de368bfa