Closed
Bug 1646409
Opened 5 years ago
Closed 5 years ago
Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` in devtools tests
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox79 fixed)
RESOLVED
FIXED
Firefox 79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We copy pasted uncesarry gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser); in many devtools tests:
https://searchfox.org/mozilla-central/search?q=gBrowser.selectedTab+%3D+BrowserTestUtils.addTab%28gBrowser%29%3B&path=devtools%2F&case=true®exp=false
as they are often followed by a call to addTab(...), without expecting to have more than one additional tab being opened.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → poirot.alex
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Summary: Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` is devtools tests → Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` in devtools tests
|
||
Updated•5 years ago
|
Attachment #9157565 -
Attachment description: Bug 1646409 - Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` is devtools tests. → Bug 1646409 - Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` in devtools tests.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f69ae64240f5
Remove unecessary `gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);` in devtools tests. r=nchevobbe
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in
before you can comment on or make changes to this bug.
Description
•