1621620 - Remove dead code in `nsFrameSelection`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1621620: part 1) Remove dead code in `nsFrameSelection`. r=jfkthame

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1621620: part 2) Declare `nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree` `const`. r=jfkthame

Depends on D66393

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1621620: part 3) Annotate `nsFrameSelection::MoveCaret` with `MOZ_CAN_RUN_SCRIPT`. r=jfkthame

Depends on D66394

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1621620: part 4) Replace remaining "unsafe" comments in `nsFrameSelection` with `MOZ_CAN_RUN_SCRIPT_BOUNDARY`. r=jfkthame

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ec9d76bd459
part 1) Remove dead code in `nsFrameSelection`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/1ea98ae8b067
part 2) Declare `nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree` `const`. r=jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a512c0bc0a8
part 3) Annotate `nsFrameSelection::MoveCaret` with `MOZ_CAN_RUN_SCRIPT`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/1656b5863fe2
part 4) Replace remaining "unsafe" comments in `nsFrameSelection` with `MOZ_CAN_RUN_SCRIPT_BOUNDARY`. r=jfkthame

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2ec9d76bd459
https://hg.mozilla.org/mozilla-central/rev/1ea98ae8b067

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6a512c0bc0a8
https://hg.mozilla.org/mozilla-central/rev/1656b5863fe2