1620952 - Merge `nsFrameSelection`'s constructor and its `Init` method

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 1) Construct `nsFrameSelection` as late as possible. r=jfkthame

Might allow to merge its constructor and its Init method.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 2) Remove `nsFrameSelection::Init`. r=jfkthame

Will allow to declare some members const.

Depends on D65953

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 3) Group delayed mouse event members in `nsFrameSelection`. r=jfkthame

Simplifies analyzing and further refactoring nsFrameSelection.

Depends on D65954

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 4) Group caret members in `nsFrameSelection`. r=jfkthame

Depends on D65957

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 5) Group limiter members in `nsFrameSelection`. r=jfkthame

Depends on D65959

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 6) Group `mDesiredPos` and `mDesiredPosSet`. r=jfkthame

Depends on D65960

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 7) Group batching members. r=jfkthame

Depends on D65961

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 8) Rename `nsFrameSelection::IsDirty`. r=jfkthame

The new name is clearer.

Depends on D66059

Comment 9

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1620952: part 9) Rename `nsFrameSelection::GetBatching` to `IsBatching`. r=jfkthame

Depends on D66060

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96bd9af83029
part 1) Construct `nsFrameSelection` as late as possible. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/b550d651df6d
part 2) Remove `nsFrameSelection::Init`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5ed69b726d14
part 3) Group delayed mouse event members in `nsFrameSelection`. r=jfkthame

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e59931951810
part 4) Group caret members in `nsFrameSelection`. r=jfkthame

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/96bd9af83029
https://hg.mozilla.org/mozilla-central/rev/b550d651df6d
https://hg.mozilla.org/mozilla-central/rev/5ed69b726d14

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e59931951810

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/539e7ef94446
part 5) Group limiter members in `nsFrameSelection`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3205728297e3
part 6) Group `mDesiredPos` and `mDesiredPosSet`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/d2d182489323
part 7) Group batching members. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3127ea7cec4d
part 8) Rename `nsFrameSelection::IsDirty`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/a1d045de7bc4
part 9) Rename `nsFrameSelection::GetBatching` to `IsBatching`. r=jfkthame

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/539e7ef94446
https://hg.mozilla.org/mozilla-central/rev/3205728297e3
https://hg.mozilla.org/mozilla-central/rev/d2d182489323
https://hg.mozilla.org/mozilla-central/rev/3127ea7cec4d
https://hg.mozilla.org/mozilla-central/rev/a1d045de7bc4