1613378 - Reduce dependencies from `Selection::MaybeAddTableCellRange` to `mFrameSelection`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

A preparatory step to decouple the code which keeps a Selection's styled ranges sorted and disjunct. As DocumentOrShadowRoot will keep a list of sorted disjunct ranges, the corresponding code will have to be factored out from Selection.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 1) Decouple `Selection::GetTableSelectionType` from `Selection` class. r=smaug

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 2) Remove unnecessary dependency from `nsFrameSelection::GetCellLayout` to `mPresShell` and declare it static. r=smaug

Depends on D61691

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 3) Remove `Selection::GetTableCellLocationFromRange`'s dependency to `mFrameSelection` and declare it static. r=smaug

Depends on D61692

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a1c680c8740
part 1) Decouple `Selection::GetTableSelectionType` from `Selection` class. r=smaug
https://hg.mozilla.org/integration/autoland/rev/11d012aeef35
part 2) Remove unnecessary dependency from `nsFrameSelection::GetCellLayout` to `mPresShell` and declare it static. r=smaug
https://hg.mozilla.org/integration/autoland/rev/743fb8cbcce4
part 3) Remove `Selection::GetTableCellLocationFromRange`'s dependency to `mFrameSelection` and declare it static. r=smaug

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 4) Declare some methods in `nsFrameSelection` static. r=smaug

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 5) Decouple `UserSelectRangesToAdd` from `Selection` class. r=smaug

Depends on D62037

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 6) Remove copy&pasted `IsValidSelectionPoint` function. r=smaug

Depends on D62038

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 7) Remove `Selection`'s default constructor. r=smaug

Removes duplicated code and reveals the dependency to frame selection.

Depends on D62039

Comment 9

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 8) Add assertion to `nsAutoScrollTimer::Init`. r=smaug

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5a1c680c8740
https://hg.mozilla.org/mozilla-central/rev/11d012aeef35
https://hg.mozilla.org/mozilla-central/rev/743fb8cbcce4

Comment 11

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 9) Clarify dependency to `mFrameSelection` in `Selection` when adding/removing ranges. r=smaug

Moreover, this is potentially more efficient because
GetRangesForIntervalArray doesn't have to be called when there's no
frame selection.

Comment 12

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1613378: part 10) Declare some table/Selection related method arguments const. r=smaug

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b49700eb1596
part 4) Declare some methods in `nsFrameSelection` static.  r=smaug
https://hg.mozilla.org/mozilla-central/rev/0ea74c8ad137
part 5) Decouple `UserSelectRangesToAdd` from `Selection` class. r=smaug

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b49700eb1596
https://hg.mozilla.org/mozilla-central/rev/0ea74c8ad137

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3baf3407cbe
part 6) Remove copy&pasted `IsValidSelectionPoint` function. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6fe76439f1d3
part 7) Remove `Selection`'s default constructor. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e3a2ab6d7267
part 8) Add assertion to `nsAutoScrollTimer::Init`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/cee4bbabc4b5
part 9) Clarify dependency to `mFrameSelection` in `Selection` when adding/removing ranges. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f38b806ee78b
part 10) Declare some table/Selection related method arguments const. r=smaug

Comment 16

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1613378) for mochitest failures at test_general.html.
https://hg.mozilla.org/integration/autoland/rev/cb0bb295c5e69a885a5eee9e6ccd7edeb2ac210e

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=f38b806ee78beb57d6027b31a5dd10b0ceacf60f&selectedJob=288327107

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288327107&repo=autoland&lineNumber=4002

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d7ceea5ffb7
part 6) Remove copy&pasted `IsValidSelectionPoint` function. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d301a063f64f
part 7) Remove `Selection`'s default constructor. r=smaug
https://hg.mozilla.org/integration/autoland/rev/0f4ea01a8e97
part 8) Add assertion to `nsAutoScrollTimer::Init`. r=smaug

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0d7ceea5ffb7
https://hg.mozilla.org/mozilla-central/rev/d301a063f64f
https://hg.mozilla.org/mozilla-central/rev/0f4ea01a8e97

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41809d86171c
part 9) Clarify dependency to `mFrameSelection` in `Selection` when adding/removing ranges. r=smaug
https://hg.mozilla.org/integration/autoland/rev/5177b7449ca5
part 10) Declare some table/Selection related method arguments const. r=smaug

Comment 20

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/41809d86171c
https://hg.mozilla.org/mozilla-central/rev/5177b7449ca5