Closed
Bug 1608276
Opened 5 years ago
Closed 3 years ago
Stop using the subscript loader to add to the global in JSMs
Categories
(Firefox :: General, task, P5)
Firefox
General
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: mossop, Assigned: arai)
References
Details
Attachments
(3 files, 1 obsolete file)
This won't be possible with ES6 modules.
| Assignee | ||
Updated•3 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•3 years ago
|
||
| Assignee | ||
Comment 2•3 years ago
|
||
Depends on D144079
| Assignee | ||
Comment 3•3 years ago
|
||
Depends on D144080
Updated•3 years ago
|
Attachment #9272953 -
Attachment description: WIP: Bug 1608276 - Part 1: Use ChromeUtils.import instead of Services.scriptloader.loadSubScript in subprocess JSMs. → Bug 1608276 - Part 1: Use ChromeUtils.import instead of Services.scriptloader.loadSubScript in subprocess JSMs. r=Mossop
Updated•3 years ago
|
Attachment #9272954 -
Attachment description: WIP: Bug 1608276 - Part 2: Use ChromeUtils.import instead of Services.scriptloader.loadSubScript in OSCrypto.jsm. → Bug 1608276 - Part 2: Use ChromeUtils.import instead of Services.scriptloader.loadSubScript in OSCrypto.jsm. r=Mossop
Updated•3 years ago
|
Attachment #9272955 -
Attachment description: WIP: Bug 1608276 - Part 3: Do not use global this whem loading sinon subscript. → Bug 1608276 - Part 3: Do not use global this whem loading sinon subscript. r=Mossop
| Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Attachment #9272953 -
Attachment is obsolete: true
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/7c763f5a2f81
Part 1: Do not use global this when loading subprocess scripts. r=mossop
https://hg.mozilla.org/integration/autoland/rev/ff3d33b28162
Part 2: Use ChromeUtils.import instead of Services.scriptloader.loadSubScript in OSCrypto.jsm. r=mossop
https://hg.mozilla.org/integration/autoland/rev/8bb44ba34a67
Part 3: Do not use global this whem loading sinon subscript. r=mossop
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c763f5a2f81
https://hg.mozilla.org/mozilla-central/rev/ff3d33b28162
https://hg.mozilla.org/mozilla-central/rev/8bb44ba34a67
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•