1584253 - Implement verdi's "One-off Search Squishiness" design for narrow windows

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Dão Gottwald [:dao]]

(In reply to Harry Twyford [:harry] from bug 1581753 comment #6)

Verdi produced a spec for this that resizes with the page: https://firefox.michaelverdi.com/squish/. The minimum row width should match the length of the localized string.

Comment 1

[Harry Twyford]

I spoke to Verdi about this, and he says it should block Megabar getting to Release. He highlighted that the temporary fix in bug 1581753 still isn't ideal. The one-off width problem is especially bad since we leave the megabar view open during window resize.

Comment 2

[Dão Gottwald [:dao]]

I spoke to Verdi about this, and he says it should block Megabar getting to Release.

In an ideal world I would agree. Realistically I highly doubt that we would potentially let the megabar miss 71 over this. It's an edge case, and the proposed solution seems tricky to implement. I suspect we'll have more important things to spend our time on.

He highlighted that the temporary fix in bug 1581753 still isn't ideal.

Of course it isn't. Nobody ever said it was.

The one-off width problem is especially bad since we leave the megabar view open during window resize.

We can revert that behavior change if needed.

Comment 3

[Asif Youssuff]

Attachment: Screenshot from 2019-10-03 10-38-09.png

I was going to report this as a new issue, but this was already filed. This isn't that much of an edge case if you are on a 1920 x 1080 screen and you split windows side by side.

See screenshot of how it looks.

Comment 4

[Marco Bonardo [:mak]]

You also have the search bar visible, that further compresses the urlbar (not trying to minimize the gravity, just pointing out an interesting fact)

Comment 5

[Asif Youssuff]

You also have the search bar visible, that further compresses the urlbar (not trying to minimize the gravity, just pointing out an interesting fact)

I do tend to use the separate search bar for searches, especially because Bug 1577924 is still open, and because Bug 1292321 was closed.

There also isn't friendly way to disable one off searches in the preference UI, so this will affect people who use a separate search box. Bug 1292511 was closed around this as well.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Asif Youssuff from comment #3)

Created attachment 9098588 [details]
Screenshot from 2019-10-03 10-38-09.png

I was going to report this as a new issue, but this was already filed. This isn't that much of an edge case if you are on a 1920 x 1080 screen and you split windows side by side.

See screenshot of how it looks.

Perhaps not ideal but not a failure case either. The area compresses as expected and nothing overflows. Problems occur when there's even less space. So yes, I maintain that we're talking about an edge case here.

Comment 7

[Asif Youssuff]

I remember when Phoenix 0.1 opened a separate dialog to enter addresses - something to consider if the window is too small maybe?

Comment 8

[Marco Bonardo [:mak]]

Attachment: Bug 1584253 - Better narrow-window layout for the address bar one-off buttons. r=dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32f7be1fc656
Better narrow-window layout for the address bar one-off buttons. r=dao

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/32f7be1fc656