1583731 - [Wayland] Implement Wayland DMABuf texture backend for WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

We need to extent Wayland DMABuf texture backend (Bug 1578380) for WebRenderer.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: webrender-wayland-dmabuf.patch

WIP patch, I'm getting this error with it:

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to compile shader: brush_image
0:1236(27): error: no matching function for call to `textureSize(samplerExternalOES, int)'; candidates are:
0:1236(27): error: int textureSize(sampler1D, int)
0:1236(27): error: int textureSize(isampler1D, int)
0:1236(27): error: int textureSize(usampler1D, int)
....

so it needs more work on the GL side.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #1)

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to compile shader: brush_image
0:1236(27): error: no matching function for call to `textureSize(samplerExternalOES, int)'; candidates are:
0:1236(27): error: int textureSize(sampler1D, int)
0:1236(27): error: int textureSize(isampler1D, int)
0:1236(27): error: int textureSize(usampler1D, int)

I wonde why I get this bug, as GL_OES_EGL_image_external_essl3 is supported on my system and the shader is compiled with

#version 300 es

which is GLES 3.0 which is supposed to support samplerExternalOES.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

I see it's https://github.com/servo/webrender/issues/3310
(I added #extension OES_EGL_image_external_essl3 : enable) to shader).

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Hm, looks like I do something wrong here. ES3 should be enabled on WebRender, OES_EGL_image_external_essl3 is supported.
When I hardcode:

#define WR_FEATURE_TEXTURE_EXTERNAL 1

to the shader I get:

Hit MOZ_CRASH(Caught GL error 502 at tex_sub_image_3d_pbo) at gfx/wr/webrender/src/device/gl.rs:1253

which does not look correct.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #2)

(In reply to Martin Stránský [:stransky] from comment #1)

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to compile shader: brush_image
0:1236(27): error: no matching function for call to `textureSize(samplerExternalOES, int)'; candidates are:
0:1236(27): error: int textureSize(sampler1D, int)
0:1236(27): error: int textureSize(isampler1D, int)
0:1236(27): error: int textureSize(usampler1D, int)

Filed as https://gitlab.freedesktop.org/mesa/mesa/issues/1901

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9098488 [details] [diff] [review]
webrender-wayland-dmabuf.patch

Review of attachment 9098488 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for my slow feedback. The patch looks good! As in Comment 5, the shader problems seems like a different problem.
I tried to test the patch. But nsWaylandDisplay::IsDMABufEnabled() returned false on my Ubuntu 18.04 by the following. Is there a way to enable DMABuf on Ubuntu 18.04?

https://searchfox.org/mozilla-central/source/widget/gtk/nsWaylandDisplay.cpp#458
>  if (!display->GetGbmFormat(/* aHasAlpha */ false) ||
>      !display->GetGbmFormat(/* aHasAlpha */ true)) {

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Thanks for testing! It should be enough to set widget.wayland_dmabuf_backend.enabled to true at about:config.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Btw. Did that DMABUF init failed with "Failed to create obtain pixel format, DMABUF/DRM won't be available!" ?

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #5)

Filed as https://gitlab.freedesktop.org/mesa/mesa/issues/1901

Mesa is fix is on the way so we can proceed here.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1583731 - [Wayland] Assert when EGLImage is already created at WaylandDMABufSurface::CreateEGLImage, r=jhorak

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1583731 - [Wayland] Implement RenderWaylandDMABUFTextureHostOGL based on WaylandDMABUFSurface, r=sotaro

Depends on D49263

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1583731 - [Wayland] Use WebRender WaylandDMABufSurface backend when dmabuf is enabled, r=sotaro

Depends on D49264

Comment 13

[Martin Stránský [:stransky] (ni? me)]

To get it working you also need mesa with a patch from https://gitlab.freedesktop.org/mesa/mesa/issues/1901

Comment 14

[Sotaro Ikeda [:sotaro]]

(In reply to Martin Stránský [:stransky] from comment #8)

Btw. Did that DMABUF init failed with "Failed to create obtain pixel format, DMABUF/DRM won't be available!" ?

On Ubuntu 18.04, dmabuf_modifiers() was not called. It seemed to make nsWaylandDisplay::GetGbmFormat() failure.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

(In reply to Sotaro Ikeda [:sotaro] from comment #14)

On Ubuntu 18.04, dmabuf_modifiers() was not called. It seemed to make nsWaylandDisplay::GetGbmFormat() failure.

Yes, that means your Wayland compositor does not support zwp_linux_dmabuf_v1 version 3. It should be at mutter-3.25.90 [1] but I'm not entirely sure the which version. I have mutter-3.32.2 (Fedora 30).

[1] https://github.com/GNOME/mutter/blob/master/NEWS

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/927679118b14
[Wayland] Assert when EGLImage is already created at WaylandDMABufSurface::CreateEGLImage, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/10315b0f4304
[Wayland] Implement RenderWaylandDMABUFTextureHostOGL based on WaylandDMABUFSurface, r=sotaro
https://hg.mozilla.org/integration/autoland/rev/1dfc280e1f0e
[Wayland] Use WebRender WaylandDMABufSurface backend when dmabuf is enabled, r=sotaro

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/927679118b14
https://hg.mozilla.org/mozilla-central/rev/10315b0f4304
https://hg.mozilla.org/mozilla-central/rev/1dfc280e1f0e