1570278 - Some async test262 tests for dynamic import fail

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[André Bargull [:anba]]

When enabling dynamic import() tests when running test262 in the browser (bug 1570011), the following tests failed:

• test262/language/expressions/dynamic-import/catch/nested-arrow-import-catch-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-async-function-await-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-block-labeled-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-do-while-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-else-import-catch-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-if-import-catch-instn-iee-err-ambiguous-import.js
• test262/language/expressions/dynamic-import/catch/nested-while-import-catch-instn-iee-err-ambiguous-import.js

It looks like jsTestDriverEnd is called before $DONE, so maybe it's necessary to modify gDelayTestDriverEnd and manually call jsTestDriverEnd for async tests.

Comment 1

[André Bargull [:anba]]

Different try-runs show failures in different tests, so it seems best to keep all dynamic import() tests disabled in the browser until this bug is fixed.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1570278 - Part 1: Add 'async' flag for asynchronous test262 tests. r=jonco!

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1570278 - Part 2: Reimport test262 files. r=jonco!

Depends on D40087

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d042d7e63a114f64d66e6905412da1567a8e835

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa8554671087
Part 1: Add 'async' flag for asynchronous test262 tests. r=jonco
https://hg.mozilla.org/integration/autoland/rev/c5ee864490dc
Part 2: Reimport test262 files. r=jonco

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fa8554671087
https://hg.mozilla.org/mozilla-central/rev/c5ee864490dc