1568968 - Re-enable existing print telemetry on release

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P2)

Description

[Stella Ma]

Attachment: telemetry_request.txt

Data review request to renew existing printing-related probes.

Comment 1

[Megan McCorquodale]

Comment on attachment 9080723 [details]
telemetry_request.txt

	1.	Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way? 
Yes, this will be included in the probe dictionary. 

	2.	Is there a control mechanism that allows the user to turn the data collection on and off? 
Yes, this can be turned off by opting out of telemetry collection. 

	3.	If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Martin Balfanz. 

	4.	Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2 - Interaction data. 

	5.	Is the data collection request for default-on or default-off?

Default on. 

	6.	Does the instrumentation include the addition of any new identifiers?

No new identifiers. 

	7.	Is the data collection covered by the existing Firefox privacy notice?
Yes. 

	8.	Does there need to be a check-in in the future to determine whether to renew the data? 

No. 

	9.	Does the data collection use a third-party collection tool? 
No. 

--- 
data-review +

Comment 2

[Sean Voisen (:svoisen)]

jwatt: Is this something you can prioritize and handle relatively soon? We'd like to get this re-enabled and also ultimately uplifted to ESR. If not, I can get someone more familiar with telemetry involved, but since you're already in the printing code for Fission I thought this might make sense.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten

Comment 4

[Jonathan Watt [:jwatt]]

That was much easier to do than the last time I had to work with Telemetry code!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae37581037fd
Re-enable existing print telemetry for nightly, beta and release. r=chutten

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ae37581037fd

Comment 7

[Jonathan Watt [:jwatt]]

[Tracking Requested - why for this release]: Martin Balfanz would like to have this uplifted to help with the printing project. I believe mkaply is aware.

Comment 8

[Martin Balfanz [:mbalfanz]]

Correct, we'd like to track printing asap across all channels. This uplift was discussed with :RT and I believe with mkaply.

Comment 9

[Mike Kaply [:mkaply]]

Yes, although it's 68, not 60

Comment 10

[Jonathan Watt [:jwatt]]

Comment on attachment 9088123 [details]
Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: To gather information about printing usage in corporate environments.
• User impact if declined: Delays the printing project.
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simply re-enabling some telemetry that expired.
• String or UUID changes made by this patch: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Did you intend to request Beta approval on this also for Fx70?

Comment 12

[Jonathan Watt [:jwatt]]

Yes, I should probably have done that too.

Comment 13

[Jonathan Watt [:jwatt]]

Comment on attachment 9088123 [details]
Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten

Beta/Release Uplift Approval Request

See comment 10.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

When did this expire? In 60? If so then are we sure we won't run into problems (perf or some other issue) given there have been a lot of changes to the codebase between 60 and now?

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Martin, how urgent is this to get into 70? I would have taken this earlier in beta, but this is the very last beta build, and I don't want to add risk to the 70 release. So, I'd prefer this change ride with 71.

Comment 16

[Mike Kaply [:mkaply]]

We really need this in order to know what to focus on for the printing project in 4Q, and it's low risk.

Basically we'll lose six weeks of data.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9088123 [details]
Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten

OK, let's give this a try on beta.

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63e23e5ce811

Comment 19

[Martin Balfanz [:mbalfanz]]

Yes, what :mkaply said. I'm very sorry that we are late with this uplift.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9088123 [details]
Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten

Approved for 68.2esr also.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/bdcc7ff3b644