1568185 - Remove bindObjectCreator options from the console actor

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

It looks like this options, passed to the evaluation methods of the console actor aren't used anymore:
https://searchfox.org/mozilla-central/search?q=bindObjectActor&case=false&regexp=false&path=
We should remove all occurences of it and remove the related test.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1568185 - Remove unused bindObjectActor argument from console actor.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1568185 - Remove unused bindObjectActor argument from console actor.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46c3a1fdc706
Remove unused bindObjectActor argument from console actor. r=nchevobbe

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 2 changesets (Bug 1568203, Bug 1568185) for ES lint failure on eval-with-debugger.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=adc394f833f95918313bb71ed4249fc117d96524&tochange=73a5452606a89b96b833a4171fff407dad93dc3d&selectedJob=258059020

Backout link: https://hg.mozilla.org/integration/autoland/rev/73a5452606a89b96b833a4171fff407dad93dc3d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258059020&repo=autoland&lineNumber=222

[task 2019-07-24T07:57:55.441Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-07-24T07:57:55.441Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-07-24T07:57:55.441Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-07-24T07:57:55.441Z]
[task 2019-07-24T07:57:55.441Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-24T08:11:43.909Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/webconsole/eval-with-debugger.js:10:9 | 'Cu' is assigned a value but never used. (no-unused-vars)
[taskcluster 2019-07-24 08:11:44.241Z] === Task Finished ===
[taskcluster 2019-07-24 08:11:45.057Z] Unsuccessful task run with exit code: 1 completed in 1152.148 seconds

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f35681ded83
Remove unused bindObjectActor argument from console actor. r=nchevobbe

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2f35681ded83