1559392 - [about:addons] Support installing non-.xpi files with drag and drop

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot

Environment

• Darwin 18.6.0
• https://hg.mozilla.org/mozilla-central/rev/6c5b432d7460f7ffd715e988fa179a93d4f7e4ae

Steps to Reproduce

1. Drag & Drop addon's zip file to the empty area which I illustrate in the screenshot in about:addons (html version).

Actual Behavior

Try to download the zip file that I drag & drop.

Expected Behavior

Show the doorhanger to attempt to install the addon.
The XUL version of about:addons did it.

Comment 1

[Mark Striemer [:mstriemer]]

This is on a Mac? What OS version? Wikipedia seems to suggest 18.2.0 is the latest Darwin version.

This works for me on Mac OS 10.14.

Can you submit a screencast so I can see how you're dragging the file in if that has any impact? Thanks!

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

This is on a Mac? What OS version? Wikipedia seems to suggest 18.2.0 is the latest Darwin version.
This works for me on Mac OS 10.14.

Yes. I reproduced on my macOS 10.14. I'm sorry to copy & paste from about:support.

Can you submit a screencast so I can see how you're dragging the file in if that has any impact? Thanks!

I'll attach the screencast of the actual behavior.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screencast of the actual behavior

Comment 4

[Mark Striemer [:mstriemer]]

So I tried this again after renaming the .xpi file I was using to a .zip and I see the same behaviour. Dragging anywhere into the HTML pane clears the document but dragging it onto the sidebar will start the install.

Do .xpi files work for you?

Comment 5

[Mark Striemer [:mstriemer]]

Looks like this was working in my previous tests because dropping an xpi in any tab will try to install it, but about:addons tries to install whatever you give it, regardless of file type.

Fairly straightforward to fix, however updating the XUL tests for the HTML version results in a not very helpful stack trace. I'll need to look into this more later.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Mark Striemer [:mstriemer] from comment #4)

Do .xpi files work for you?

.xpi works in my environment for about:addons html.

I used to debug or dogfooding my addon instantly to install it by drag&drop .zip archive.

Comment 7

[Mark Striemer [:mstriemer]]

The sidebar is being removed in bug 1525178, which will break the last place you could drop .zip files to be installed. I'm not sure how big of an issue this will be, but we're still running into the same test issues moving the tests to target the HTML document.

I'll remove the existing code and hopefully we can add it back at a later date.

If this is a big issue please let me know, I'd imagine most users haven't discovered the ability to drag a .zip onto the sidebar so not supporting this is likely the expected behaviour for most users.

Comment 8

[Mark Striemer [:mstriemer]]

The sidebar is being converted to HTML so support for this will likely be removed until we switch to a root HTML document in bug 1525179. Adding the dependency. Installing .xpi files will still work, but unfortunately we can't test this functionality while we have to implement it in the inner HTML document.

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1559392 - Support drag+drop of add-ons into HTML about:addons

Depends on D65834

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2009a877d90f
Support drag+drop of add-ons into HTML about:addons r=rpl

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2009a877d90f