1558896 - Consider future of telemetry for plugin enable/disable / detail view events

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect, P3)

Description

[:Gijs (he/him)]

After bug 1519434 it will no longer be possible to "always allow" flash (our only supported plugin in the real world).

It's not clear if anyone actually cares about this telemetry at the moment.

The telemetry does not have events for when "ask to activate" is selected as the userDisabled state.

This bug could be resolved in a few different ways:

1. remove the telemetry
2. update the telemetry and associated tests to no longer consider "enable" and instead consider "ask to activate"
3. only remove the "enable" event

I'd lean towards removing unless there's someone who is actively using this event telemetry. In light of our changes to the blocklist implementation, I might take a different view on telemetry for overall numbers of enabled/disabled/blocked add-ons, but I think these probes only reflect events inside the addon manager UI so they don't really give an insight in that anyway.

I don't know who makes the call on this one. :mstriemer, do you?

Comment 1

[Gregory Pappas [:gregp]]

Is this bug still relevant?

Comment 2

[:Gijs (he/him)]

No, I think this relates to https://phabricator.services.mozilla.com/D34215#inline-205081 and that probe is PLUGINS_NOTIFICATION_USER_ACTION_2 which has been removed. Let's close this out.