1543650 - Replace JSMSG_NOT_BIGINT with more descriptive error messages

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

https://searchfox.org/mozilla-central/rev/69ace9da347adcc4a33c6fa3d8e074759b91068c/js/src/vm/BigIntType.cpp#2687 should include the type and/or value of v. So instead of throwing TypeError: not a BigInt, it should throw TypeError: can't convert xxx to BigInt.

Example:

js> new BigInt64Array([2])
typein:1:1 TypeError: not a BigInt
Stack:
  @typein:1:1

---

https://searchfox.org/mozilla-central/rev/69ace9da347adcc4a33c6fa3d8e074759b91068c/js/src/vm/TypedArrayObject.cpp#1355 and https://searchfox.org/mozilla-central/rev/69ace9da347adcc4a33c6fa3d8e074759b91068c/js/src/vm/TypedArrayObject.cpp#1768 should include the source and target typed array types or describe somehow that the typed array element types are incompatible.

Example:

js> new BigInt64Array(new Int32Array)
typein:2:1 TypeError: not a BigInt
Stack:
  @typein:2:1

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1543650 - Throw better error message in ToBigInt. r?arai

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1543650 - Improve error message when using incompatible typed (BigInt) arrays. r?arai

I am open to wording improvements for the error message. Right now we get:

js> new BigInt64Array(new Float32Array(4))
TypeError: Float32Array array elements are incompatible with BigInt64Array

and

js> x = new Float32Array(4); x.set(new BigInt64Array(2))
TypeError: BigInt64Array array elements are incompatible with Float32Array

Depends on D57199

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9980078d96a3
Throw better error message in ToBigInt. r=arai
https://hg.mozilla.org/integration/autoland/rev/3b3c8d649109
Improve error message when using incompatible typed (BigInt) arrays. r=arai

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9980078d96a3
https://hg.mozilla.org/mozilla-central/rev/3b3c8d649109